Stop javascript from executing

Question

I know this is simple but I cant get the conditional if below to work...

This line below " if ( !$section.id == "no-transition" ) " is not correct.

I'm trying to stop javascript from working on section elements that have the id of "no-transition".

Can someone point me in the right direction?

function initEvents() {

    $sections.each( function() {

            var $section = $( this );

            if ( !$section.id == "no-transition" ) { 
            // expand the clicked section and scale down the others
            $section.on( 'click', function() {

                    [code taken out to shorten post...]

                    if( !supportTransitions ) {
                            $section.removeClass( 'bl-expand-top' );
                    }

                    $el.removeClass( 'bl-expand-item' );

                    return false;

            } );
           }
} );

You really should not have multiple elements with the same id on a page. Its baad! — techfoobar
– techfoobar, Commented May 4, 2013 at 14:00
This is why you should always use != and never !... ==. :) — Ry-
– Ry- ♦, Commented May 4, 2013 at 14:02
You have syntax error in your code. Where is the } for the function? — user1823761
– user1823761, Commented May 4, 2013 at 14:03
To be more clear about why you should not have the same id for multiple elements: the id attribute is not built to have the same value assigned to multiple elements. If you attempt to .getElementById or use some kind of jQuery event handler like $('#no-transition').click(... it will only return/be applied to the first element. If you want to act on multiple elements, use a shared class attribute value. — CrayonViolent
– CrayonViolent, Commented May 4, 2013 at 14:13
if I changed it to a class what would the corresponding conditional if be? if ($section.attr('class') != "no-transition") ? — Joe Crocetta
– Joe Crocetta, Commented May 4, 2013 at 14:22

techfoobar · Accepted Answer · 2013-05-04 14:01:24Z

3

You really should not have multiple elements with the same id on a page.

Your if condition should be modified to:

...
if ( $section.attr('id') != "no-transition" ) { 
   ...

answered May 4, 2013 at 14:01

techfoobar

66.8k14 gold badges117 silver badges138 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Joe Crocetta Over a year ago

Superb techfoobar! I apologize I didn't have enough javascript experience to get this one right. Thanks for everyone's comments.

Collectives™ on Stack Overflow

Stop javascript from executing

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related