JS: pass variable onclick

Question

I'm trying to pass a variable to a function, I know there are many topics about this, and I've nearly tried all suggestions, but still can't get it to work, these are my attempts:

edit: without the onclick, everything is working fine

var filename = file.name;

<button class="btn btn-danger delete" onclick="deleteImage(\''+filename+'\');">

results in: Uncaught SyntaxError: Unexpected token ILLEGAL

<button class="btn btn-danger delete" onclick="deleteImage(&quot;'+type+'&quot;);">

results in (alert): 'filename'

<button class="btn btn-danger delete" onclick="deleteImage('" + filename + "');">

results in: Uncaught SyntaxError: Unexpected token ILLEGAL

<button class="btn btn-danger delete" onclick="deleteImage(" + filename + ");">

result in: Uncaught SyntaxError: Unexpected token }

this is the full code (modified, blueimp fileuploader)

    <script id="template-download" type="text/x-tmpl">
{% for (var i=0, file; file=o.files[i]; i++) { %}
    <tr class="template-download fade">
        {% if (file.error) { %}
            <td></td>
            <td class="name"><span>{%=file.name%}</span></td>
            <td class="size"><span>{%=o.formatFileSize(file.size)%}</span></td>
            <td class="error" colspan="2"><span class="label label-important">Error</span> {%=file.error%}</td>
        {% } else { 
            // add the image urls to the file inputbox
            var filename = file.name;
            var prev = $("#mFile").val(); 
            $("#mFile").val(prev + file.name + ","); 

            %}
            <td class="preview">{% if (file.thumbnail_url) { %}
                <a href="modules/mod_stern_form_prijsopgave/upload/server/php/files/{%=file.name%}" title="{%=file.name%}" data-gallery="gallery" download="{%=file.name%}"><img src="modules/mod_stern_form_prijsopgave/upload/server/php/files/thumbnail/{%=file.name%}"></a>
            {% } %}</td>
            <td class="name">
                <a href="modules/mod_stern_form_prijsopgave/upload/server/php/files/{%=file.name%}" title="{%=file.name%}" data-gallery="{%=file.thumbnail_url&&'gallery'%}" download="{%=file.name%}">{%=file.name%}</a>
            </td>
            <td class="size"><span>{%=o.formatFileSize(file.size)%}</span></td>
            <td colspan="2"></td>
        {% } %}
        <td>
            <button class="btn btn-danger delete" onclick="deleteImage('" + filename + "');" data-type="{%=file.delete_type%}" data-url="{%=file.delete_url%}"{% if (file.delete_with_credentials) { %} data-xhr-fields='{"withCredentials":true}'{% } %}>
                <i class="icon-trash icon-white"></i>
                <span>Verwijderen</span>
            </button>
        </td>
    </tr>
{% } %}
</script>

and testing like this:

    function deleteImage(filename) {
      alert(filename);
    }

what am I doing wrong? Thanks for your advice

What system is this? Looks like it might be jQuery templates or knockoutjs? This question needs better tagging. — drquicksilver
– drquicksilver, Commented Apr 11, 2013 at 12:12

gp. · Accepted Answer · 2013-04-11 12:56:15Z

3

try the template format for onclick value:

onclick="deleteImage('{%=filename%}');"

try file.name as well

onclick="deleteImage('{%=file.name%}');"

answered Apr 11, 2013 at 12:56

gp.

8,2533 gold badges42 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Maarten Hartman Over a year ago

lol..I've tried something close to this.. this worked! thank you so much. this might bring a grin upon your face: I just spent 2 hours on this

user2153497 · Accepted Answer · 2013-04-11 12:22:39Z

3

<button id="deleteOnClick" class="btn btn-danger delete">...</button>

and in javascript:

document.getElementById("deleteOnClick").onclick = function(){deleteImage(filename);}

edit:

if you want to delete the file specified only by the original filename value:

var deleteByFile = (function (filename){
    return function(){deleteImage(filename);};
}(filename));
document.getElementById("deleteOnClick").onclick = deleteByFile

edited Apr 11, 2013 at 12:22

answered Apr 11, 2013 at 12:14

user2153497

3562 gold badges4 silver badges9 bronze badges

3 Comments

Maarten Hartman Over a year ago

all suggestions resulted in: Uncaught TypeError: Cannot set property 'onclick' of null

user2153497 Over a year ago

did you add the id to the button? if not then you can use $(".btn-danger").click(deleteByFile); instead.

Maarten Hartman Over a year ago

fixed it now using gp.'s answer, thanks a lot for your help mate

tckmn · Accepted Answer · 2013-04-11 12:29:08Z

2

You can't access JS variables from your HTML. You must do something like this:

var filename = 'testing';
document.getElementById('testdiv')
    .setAttribute('onclick', "alert('" + filename + "')");
filename = 'more testing';

Here is a fiddle.

edited Apr 11, 2013 at 12:29

answered Apr 11, 2013 at 12:12

tckmn

59.6k27 gold badges118 silver badges156 bronze badges

6 Comments

Maarten Hartman Over a year ago

I've tried this one aswell, results in: Uncaught SyntaxError: Unexpected token }

tckmn Over a year ago

@MaartenHartman Well then it's a problem somewhere else in the code, because my code most definitely does NOT have a }.

Maarten Hartman Over a year ago

I know, and normally your suggestion should work, but without the onclick everything is working fine, so the code isn't flawed.

Maarten Hartman Over a year ago

thanks for your help so far, last suggestion resulted in: Uncaught TypeError: Cannot set property 'onclick' of null

tckmn Over a year ago

@Maarten Well, is your div's id "testdiv"?

|

Ripa Saha · Accepted Answer · 2013-04-11 12:21:48Z

0

try to use onclick="deleteImage(" + filename + ");"

answered Apr 11, 2013 at 12:21

Ripa Saha

2,5406 gold badges29 silver badges54 bronze badges

Comments

Sourja Banerjee · Accepted Answer · 2015-04-23 07:47:39Z

-1

You can set a varaiable like var counter = 1;

Wherever it is required, you can update it like

     onclick="updateCount('+counter+')"

answered Apr 23, 2015 at 7:47

Sourja Banerjee

11 silver badge

Collectives™ on Stack Overflow

JS: pass variable onclick

5 Answers 5

1 Comment

3 Comments

6 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

3 Comments

6 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related