Rendering rails partial with dynamic variables

Question

I'm trying to render a partial based on the taxon the user is inside. In my application.html.erb layout I have the following line of code:

<%= render 'spree/shared/women_subnav' if @enable_women %>

In the taxons controller, inside the show method, I have:

@taxon_id = params[:id].split('/').first

And in taxons#show I have:

<% if @taxon_id == params[:id].split('/').first %>
  <%= "@enable_#{@taxon_id}" = true %>
<% end %>

When I run this I get a SyntaxError. But in taxons#show If I just enter:

<% if @taxon_id == params[:id].split('/').first %>
  <%= "@enable_#{@taxon_id}" %>
<% end %>

without the '= true' then the page renders, outputting '@enable_women'. So I know it's getting the correct variable, I just need that variable to be set to true. What am I missing?

Thanks so much.

dennis · Accepted Answer · 2013-03-12 16:25:15Z

3

First of all I would like to give you some heads-up:

calling first on a user submittable input is not a great idea (what if I submit ?id=, it would return nil) also non utf-8 encoding will crash your app such as: ?id=Ж
Controllers are beast! I see you are setting the value of a true/false instance_variable in the view, please use controllers do define the logic before rendering its output. especially when parameter dependant.

so for a solution: in your controller as params[:id] should suggest an INT(11) value:

def action
  # returning a Taxon should be a good idea here
  @taxon = Taxon.find(params[:id])
  # as I would give a Taxon class an has_many relation to a User
  @users = @taxon.users
end

and in your action's view

<%= render :partial => "taxons/users", collection: @users %>

of course you would have the great ability to scope the users returned and render the wanted partial accordingly.

if you want more info about "The Rails way" please read: http://guides.rubyonrails.org/

Have fun!

answered Mar 12, 2013 at 16:25

dennis

2,02019 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

reknirt Over a year ago

Thank you @dennis. I will definitely keep my logic in the controller. I appreciate your help!

jvnill · Accepted Answer · 2013-03-12 15:36:18Z

1

use instance_variable_set

instance_variable_set "@enable_#{@taxon_id}", true

just a reminder that it's better to do these things inside a controller.

answered Mar 12, 2013 at 15:36

jvnill

29.6k5 gold badges86 silver badges86 bronze badges

1 Comment

reknirt Over a year ago

Would this be correct syntax inside my controller:

def show       @taxon_id = params[:id].split('/').first       if @taxon_id == params[:id].split('/').first       	instance_variable_set "@enable_#{@taxon_id}", true       end

Collectives™ on Stack Overflow

Rendering rails partial with dynamic variables

2 Answers 2

1 Comment

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related