php header redirect based on post variables

Question

I have visitors coming to my site from 5 seperate sources, each one sends a variable in the url based on where its from, in the event these sources sends visitors I want to send them to a seperate page thats more relevant to the user

<?php
     $var = $_GET["var"];
     if( $var='site1'){
              header('Location: ' . "http://www.example.com/site1page");
     }else{
              header('Location: ' . 'http://www.example.com/othersites/&?var='.$var,);
     }
?>

however no matter what $var comes in has its going to the first header location(site1page) Can anyone explain why this is happening?

pivotal · Accepted Answer · 2009-10-02 19:32:03Z

4

If that code is the actual code you are running - it is because you are using "=", the assignment operation instead of "==" the comparison operator. PHP lets you bite yourself this way without any sort of warning.

answered Oct 2, 2009 at 19:32

pivotal

7466 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Occur Over a year ago

Thanks I feel retarded right now, can't believe I missed that.

Tony Miller · Accepted Answer · 2009-10-02 19:32:02Z

0

Your code is doing assignment (the single equal sign). You want an equality test (double equals sign):

<?php if( $var=='site1') { header('Location: ' . "http://www.mysite.com/site1page"); } else { header('Location: ' . 'http://www.mysite.com/othersites/&?var='.$var,); } ?>

answered Oct 2, 2009 at 19:32

Tony Miller

9,1572 gold badges29 silver badges46 bronze badges

Comments

Citizen · Accepted Answer · 2009-10-02 19:39:31Z

0

Additionally, I think that comma in the second header line is going to give you a parse error.

answered Oct 2, 2009 at 19:39

Citizen

13.1k27 gold badges81 silver badges120 bronze badges

Collectives™ on Stack Overflow

php header redirect based on post variables

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related