PHP Redirect Header with a Variable

Question

I have a php script that updates a mysql database. Once its done, I want to redirect back to the details page. I know that this can be done in a header redirect, but I can't get it to add the variable to the address. My code that I have is below.

<?php
include "../config.php";
$_GET["hiveid"] = $HiveID;
$_GET["hivename"] = $HiveName;
$_GET["hiveloca"] = $HiveLoca;
mysql_query("UPDATE hives SET HiveName='$HiveName', LocationID='$HiveLoca' WHERE    HiveID='$HiveID'") or die (mysql_error()); 
$URL = "../hivedetails.php?HiveID=" . $HiveID;
header("Location: " . $URL);
?>

Your variable assignment seems to be the wrong way around. Shouldn't it be $HiveID = $_GET["hiveid"]; ? — dakdad
– dakdad, Commented Nov 13, 2012 at 3:13
dont you want $HiveID=$_GET["hiveid"]; ? not that there's any point simply creating new variables. — user557846
– user557846, Commented Nov 13, 2012 at 3:13
yep...This is what you have to do.. $HiveID=$_GET["hiveid"]; — Sahan De Silva
– Sahan De Silva, Commented Nov 13, 2012 at 3:18

Marc B · Accepted Answer · 2012-11-13 03:13:16Z

3

STOP WORKING ON THIS CODE and read up about SQL injection vulnerabilities. Your code is just begging for your server to get pwn3d
Learn basic PHP syntax. You're assigning your variables backwards. $HiveID = $_GET['hiveid'] is what you want, and similarly for the other two lines
Your actual problem will go away once you fix #2.

answered Nov 13, 2012 at 3:13

Marc B

362k44 gold badges433 silver badges508 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Michael Over a year ago

I have not thought about the SQL injections and I will be definitely be reading up on this more. I have switched around all of my codes and I also realized that I made a huge (newbie) mistake. I used POST in my form, not GET. Thanks again for your help and advise.

Collectives™ on Stack Overflow

PHP Redirect Header with a Variable

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related