Android Buttons adding functionality

Question

I have created some buttons in XML and I have method that will onClick open a URL. How do I link this method to my button so that on tap/onClick it will call the method.

Here's the method code:

    public void openResource() {
     Uri uri = Uri.parse("http://librarywales.org");
     Intent intent = new Intent(Intent.ACTION_VIEW, uri);
     startActivity(intent);
}

And I have created an instance of my XML Button in the onCreate method:

    public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    Button libButton = (Button) findViewById(R.id.button1);
}

How do I add that method to the libButton instance?

I have now solved the above issue with the help of 'vins' but when I run this application on the AVD and click on a button it pops up with an android message box saying. 'Unfortunately, ApplicationName has stopped working.'

Anyone know why this is?

Thanks, Dan

pixelscreen · Accepted Answer · 2012-07-19 09:43:58Z

1

Add this after your button declaration

 libButton.setOnClickListener(new OnClickListener() 
    {           
        @Override
        public void onClick(View v) 
        {
            //open resource method call here...
        }
    });

answered Jul 19, 2012 at 9:43

pixelscreen

1,9752 gold badges19 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

fklappan · Accepted Answer · 2012-07-19 09:56:48Z

1

Put

android:onClick="openResource"

In your xml file's button's property.

something like,

<Button
      android:id="@+id/button1"
      .
      .
      android:onClick="openResource"
      />

Note that this feature only is available on Android 2.1 (API Level 7) and higher

edited Jul 19, 2012 at 9:56

fklappan

3,2592 gold badges19 silver badges18 bronze badges

answered Jul 19, 2012 at 9:46

user370305

109k23 gold badges167 silver badges153 bronze badges

2 Comments

WebDevDanno Over a year ago

I thought of doing this just wasn't sure if it was more common practice to code into in the main application code. Thank you

user370305 Over a year ago

Android already provide a nice way to handle onClick() method of a View, itself of Activity.

Vins · Accepted Answer · 2012-07-19 11:22:48Z

0

public class YourActivity extends Activity  implements OnClickListener {
     public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main);

   Button libButton =(Button) findViewById(R.id.button1);
    libButton.setOnClickListener(this);

    Button OtherButton =(Button) findViewById(R.id.button2);
    OtherButton.setOnClickListener(this);


   }

 @Override
  public void onClick(View v) {

    switch (v.getId()) {
    case R.id.button1: openResource();
                           break;
    case R.id.button2: //do something for second button...

     default : break;
         }

edited Jul 19, 2012 at 11:22

answered Jul 19, 2012 at 10:23

Vins

4,1192 gold badges37 silver badges51 bronze badges

5 Comments

WebDevDanno Over a year ago

what would the default statement be for this? Thanks by the way

Vins Over a year ago

default is just break; and dont forget to add import android.view.View.OnClickListener;

WebDevDanno Over a year ago

the emulator only responds to me selecting the first button. Is this because of the line of code Button libButton =(Button) findViewById(R.id.button1); because that libButton is assigned to the id.button1

Vins Over a year ago

For second or whatever other buttons also you have to set the listener like you did for libButton.setOnClickListener(this); after getting its ID from findviewbyid(). Then you'll be able to catch the onClick event of that button. If you dont setOnClickListener , then if you click that particular button android wont sense that. I have updated it

WebDevDanno Over a year ago

Ahh right yes the logic has just hit me. Thank you for your patience vins four days into android apps!

Srinivasan · Accepted Answer · 2012-07-19 10:01:14Z

0

If you have many buttons with in the page you can use button.setOnClickListener(this);

And override the OnClick() method within the method use Switch statement to match Which View has been selected.It's optimized and efficient way....

answered Jul 19, 2012 at 10:01

Srinivasan

4,6813 gold badges30 silver badges36 bronze badges

Comments

Malek Hijazi · Accepted Answer · 2012-07-19 10:02:14Z

0

public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);

Button libButton = (Button) findViewById(R.id.button1);


libButton.setOnClickListener(new OnClickListener() 
{           
    @Override
    public void onClick(View v) 
    {
        if(v.getId()==R.id.button1){
           Uri uri = Uri.parse("http://librarywales.org");
           Intent intent = new Intent(Intent.ACTION_VIEW, uri);
           startActivity(intent);
        }
    }
});

}

answered Jul 19, 2012 at 10:02

Malek Hijazi

4,1621 gold badge28 silver badges32 bronze badges

2 Comments

WebDevDanno Over a year ago

thanks for this but there's an error with onClick(View v) it doesn't like the fact there's an @Override present.

WebDevDanno Over a year ago

also when I run this in the emulator it says Unfortunately, The Application has stopped. :/

Collectives™ on Stack Overflow

Android Buttons adding functionality

5 Answers 5

Comments

2 Comments

5 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

2 Comments

5 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related