simplify if .. else in javascript

Question

my mind is blank and I can't think of the solution...

I have the following code:

if (onlySelected === true) {
    if (r.selected == true) {
        result.push(pushValue);
    }
}
else {
    result.push(pushValue);
}

how can I simplify this code into this:

if (condition) { result.push(pushValue) }

loganfsmyth · Accepted Answer · 2012-06-08 16:42:41Z

8

Try this:

if (!onlySelected || r.selected){
    result.push(pushValue);
}

or this if you absolutely need the type equality and not just truthiness:

if (onlySelected !== true || r.selected){
    result.push(pushValue);
}

edited Jun 8, 2012 at 16:42

answered Jun 8, 2012 at 10:32

loganfsmyth

162k31 gold badges349 silver badges259 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Anthony Grist · Accepted Answer · 2012-06-08 10:32:40Z

0

if(onlySelected === false || r.selected == true) {
    result.push(pushValue);
}

answered Jun 8, 2012 at 10:32

Anthony Grist

38.4k8 gold badges64 silver badges76 bronze badges

3 Comments

Bergi Over a year ago

!== true is not equal to === false

Anthony Grist Over a year ago

@Bergi That makes absolutely no sense to me, so would you mind explaining why?

Bergi Over a year ago

For example 5 !== true, but 5 is not === false.

MaxArt · Accepted Answer · 2012-06-08 10:32:43Z

0

(!onlySelected || r.selected) && result.push(pushValue);

answered Jun 8, 2012 at 10:32

MaxArt

22.8k10 gold badges85 silver badges82 bronze badges

3 Comments

Anthony Grist Over a year ago

Using !onlySelected is going to result in type conversion where necessary. Judging from the fact they used the === comparator, rather than simply ==, this seems incorrect.

MaxArt Over a year ago

@AnthonyGrist That's true, I was supposing that onlySelected was intended as a boolean value. Same for r.selected.

Daniel van Dommele Over a year ago

onlySelected and r.selected are indeed both boolean.

d4rkpr1nc3 · Accepted Answer · 2012-06-08 10:34:10Z

0

if( (onlySelected === true && r.selected === true) || 1) {
    result.push(value)
}

answered Jun 8, 2012 at 10:34

d4rkpr1nc3

1,82713 silver badges16 bronze badges

Comments

Ian Routledge · Accepted Answer · 2012-06-08 10:34:25Z

0

I think this would work:

if(!onlySelected || (onlySelected && r.selected))
    result.push(pushValue);

answered Jun 8, 2012 at 10:34

Ian Routledge

4,0421 gold badge26 silver badges28 bronze badges

1 Comment

pimvdb Over a year ago

If !onlySelected is false, onlySelected is true so you can eliminate that one.

TrL · Accepted Answer · 2012-11-09 00:09:42Z

0

Hm, this is what I made it to.

onlySelected === !0 ? r.selected == 1 && result.push(pushValue) : result.push(pushValue)

answered Nov 9, 2012 at 0:09

TrL

302 bronze badges

Collectives™ on Stack Overflow

simplify if .. else in javascript

6 Answers 6

Comments

3 Comments

3 Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

3 Comments

3 Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related