[release/10.0] Add support for Visual Studio 2026 CMake generator for gen-buildsys.cmd
#121889
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
iikuzmychov
November 21, 2025 21:57
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Visual Studio 2026 CMake generator in the native build system configuration script. The change enables the build system to recognize and use Visual Studio 18 (2026) when generating build files.
- Adds a conditional check for VS version 18.0 to set the CMake generator to "Visual Studio 18 2026"
- Follows the existing pattern established for VS 2022 (version 17.0)
- Placed appropriately before the VS 2022 check to handle newer versions first
gen-buildsys.cmdVisual Studio 2026 CMake generator for gen-buildsys.cmd
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Visual Studio 2026 CMake generator for gen-buildsys.cmdVisual Studio 2026 CMake generator for gen-buildsys.cmd
Member
|
This was fixed in main by #120580 . I see you have submitted your change against release/10.0 branch. We require justification for all backport to release branches. Could you share why you would like to see this change backported to release/10.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
Visual Studio 18 2026CMake generator ineng/native/gen-buildsys.cmd.%_VSVersion% == "18.0"similarly to the existing Visual Studio 2022 case.Testing:
gen-buildsys.cmdselects theVisual Studio 18 2026generator when%_VSVersion%is18.0.