Skip to content

Conversation

@jkoritzinsky
Copy link
Member

Fixes #120578

Requires CMake 4.2.0 to actually work (which hasn't released yet).

Fixes #120578

Requires CMake 4.2.0 to actually work (which hasn't released yet).
Copilot AI review requested due to automatic review settings October 9, 2025 22:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for using CMake's Visual Studio 2026 generator by updating the build system to recognize VS version 18.0 and map it to the appropriate CMake generator.

Key Changes:

  • Added VS 2026 generator support to the Windows build system
  • Maps VS version 18.0 to CMake generator "Visual Studio 18 2026"

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@VSadov
Copy link
Member

VSadov commented Oct 10, 2025

Requires CMake 4.2.0 to actually work (which hasn't released yet).

Is there a way to install some beta/prerelease?

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jkoritzinsky
Copy link
Member Author

I don't think they're at an RC for 4.2.0 yet. You'd have to build it yourself. I would guess it'll come out soon though (they release pretty often).

@hoyosjs hoyosjs merged commit aed1aad into main Oct 12, 2025
150 of 152 checks passed
@stephentoub stephentoub deleted the jkoritzinsky-patch-1 branch October 17, 2025 12:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Generating VisualStudio project does not work after updating to VS 2026

4 participants