Java read object input stream into arraylist?

Question

The method below is supposed to read a binary file into an arrayList. But getting a java.io.EOFException:

at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2553)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1296)
at java.io.ObjectInputStream.readObject(ObjectInputStream.java:350)
at .... Read(Tester.java:400) 
at .... main(Tester.java:23)

Line 23 at main just calls the method, line 400 is the while loop below. Any ideas?

private static void Read() {
    try {
        ObjectInputStream objIn = new ObjectInputStream(new FileInputStream("/file.bin"));
        while (objIn.readObject() != null) {
            list.add((Libreria) objIn.readObject());
        }
        objIn.close();
    } catch(Exception e) {
        e.printStackTrace();
    }
}

user207421 · Accepted Answer · 2015-08-20 23:10:59Z

9

As per the other answers you are reading twice in the loop. Your other problem is the null test. readObject() only returns null if you have written a null, not at EOS, so there's not much point in using it as a loop termination test. The correct termination of a readObject() loop is

catch (EOFException exc)
{
 in.close();
 break;
}

edited Aug 20, 2015 at 23:10

answered Jun 27, 2011 at 0:33

user207421

312k45 gold badges324 silver badges493 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

ash Over a year ago

i thought you couldnt use break outside of loops. and how can you close in outside of try.

user207421 Over a year ago

@ash you can't. You either catch the EOFException inside the loop and break, or, catch it outside and omit the break, obviously.

David Koelle Over a year ago

So much for exceptions being used only for exceptional cases!

David Koelle Over a year ago

@EJP I agree that this is the way to use the API. I just find it unfortunate that an end of file, which would eventually occur with every file one would want to read, would be called an "exception." Instead, a method like in.isEndOfFile() might be nice. Regardless, with the API we have today, your answer is correct.

user207421 Over a year ago

@David That suggestion cannot work. The file could grow after you call isEndOfFile(). In TCP, there is no way to detect EOS other than by trying to read. EOS must therefore be a return value or side-effect of reading, and if there are no out-of-band return values available it can't be a return value: in a language with result parameters it can be a result parameter; in Java it has to be an exception. There is no way around this.

|

Jared Burrows · Accepted Answer · 2014-12-25 04:05:41Z

7

The problem is that you are calling readObject() twice in the loop. Try this instead:

MediaLibrary obj = null;
while ((obj = (MediaLibrary)objIn.readObject()) != null) {
     libraryFromDisk.add(obj);
}

edited Dec 25, 2014 at 4:05

Jared Burrows

55.9k26 gold badges160 silver badges190 bronze badges

answered Jun 26, 2011 at 14:06

Vincent Ramdhanie

103k23 gold badges143 silver badges196 bronze badges

1 Comment

ash Over a year ago

Still getting the same error on the while loop. I had tried something similar: Object obj = null; while ((obj = objIn.readObject()) != null) { if (obj instanceof MediaLibrary) { MediaLibrary list = (MediaLibrary) obj; libraryFromDisk.add(list); } }

DarthJDG · Accepted Answer · 2011-06-26 14:19:06Z

4

You're reading an object in the while test:

while (objIn.readObject() != null)

Then you're reading the next object in:

libraryFromDisk.add((MediaLibrary) objIn.readObject());

So in one iteration you should read only one object

private static void Load() {
    try {
        ObjectInputStream objIn = new ObjectInputStream(new FileInputStream("/file.bin"));
        Object object = objIn.readObject();
        while (object != null) {
           libraryFromDisk.add((MediaLibrary) object);
           object = objIn.readObject();

        }
        objIn.close();
    } catch(Exception e) {
        e.printStackTrace();
    }
}

edited Jun 26, 2011 at 14:19

DarthJDG

16.6k11 gold badges52 silver badges56 bronze badges

answered Jun 26, 2011 at 14:11

Jihed Amine

2,20820 silver badges32 bronze badges

3 Comments

ash Over a year ago

Still getting the same error on the while loop. I had tried something similar: Object obj = null; while ((obj = objIn.readObject()) != null) { if (obj instanceof MediaLibrary) { MediaLibrary list = (MediaLibrary) obj; libraryFromDisk.add(list); } }

Jihed Amine Over a year ago

Maybe the data in objIn is another problem. In ObjectInputStream's Javadoc, it's said that "primitive reads will throw EOFExceptions". Does the objIn contain primitive data ? (not instance of a class)

ash Over a year ago

It does not contain primitive data, or at least it shouldn't. This is the loop I use to write the file in a separate method. for(MediaLibrary item: library) { objOut.writeObject(item); }

SáT · Accepted Answer · 2013-07-20 11:47:34Z

0

You can try this. Good luck!

private static void Load() {
try {
    ObjectInputStream objIn = new ObjectInputStream(new FileInputStream("/file.bin"));
    boolean check=true;
    while (check) {

try{
object = objIn.readObject();
libraryFromDisk.add((MediaLibrary) object);
}catch(EOFException ex){
check=false;
}

    }
    objIn.close();
} catch(Exception e) {
    e.printStackTrace();
}
}

edited Jul 20, 2013 at 11:47

SáT

3,6922 gold badges36 silver badges52 bronze badges

answered Jul 20, 2013 at 11:27

duyetpt

1,9591 gold badge13 silver badges12 bronze badges

Collectives™ on Stack Overflow

Java read object input stream into arraylist?

4 Answers 4

7 Comments

1 Comment

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

7 Comments

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related