php oop constructor

Question

OK. here is what I'm trying to do:

class Image{

    public $_image;
    public $_extension;
    public $_mime;
    public $_size;
    public $_location;
    public $_description;

    public function __construct($image, $location){
        $this->_image = $image;
        $this->_location = $location;
        $this->_extension = getExtension();
        $this->_mime = getMime();
        $this->_size = getSize();
    }

   private functions fallow.....

}

But I keep getting an internal server error when I try to run it. When I comment out the method calls it works. So the question is can I call methods from inside the constructor or am I doing something wrong with the methods.

You should learn to check your error logs. 500 Internal Server Error is meaningless without context from the logs you have access to. Check your PHP.ini for the logging location. Often times, logging isn't enabled. You should enable it. — Brad
– Brad, Commented Mar 31, 2012 at 23:55
calling methods is fine (but you could have verified this with a simple example..) — Karoly Horvath
– Karoly Horvath, Commented Mar 31, 2012 at 23:55
Huh??? What??? I don't get the question (or prob. missing lots of info). — PeeHaa
– PeeHaa, Commented Mar 31, 2012 at 23:56
You can call methods. But you would need the method invokation syntax for that, which is $this->getBoring();. You may want to eschew pointless getters and setters though. — mario
– mario, Commented Mar 31, 2012 at 23:57
post the codes of the non class methods. There is something fishing among them — Starx
– Starx, Commented Mar 31, 2012 at 23:59

David Stockton · Accepted Answer · 2012-03-31 23:59:06Z

5

Do your functions getExtension, getMime and getSize exist? Are they methods on this class? If they are methods, they need to be called with $this->... as in

$this->_extension = $this->getExtension();

If they are not methods, and are functions, you need to make sure the files that contain/define them are loaded before you run the constructor.

answered Mar 31, 2012 at 23:59

David Stockton

2,2511 gold badge14 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

notsonoob_noobenough Over a year ago

They are member functions. I forgot about $this. Now it works. Thank for all the great responses.

James · Accepted Answer · 2014-02-18 18:02:36Z

Well ..this fragment of code will work as expected:

class Foo
{
    protected $secret = null;
    public function __construct( $data )
    {
        $this->secret = $this->makeSecret($data);
    }

    public function makeSecret( $data )
    {
        return md5( $data );
    }
}

$bar = new Foo( 'lorem ipsum' );

That is not a problem.

But you should know, that is considered to be a bad practice - to do computation/work in the constructor. It makes that class practically untestable. Instead, if you need to perform some computation before "releasing" the object to the rest of the code, you should use a factory. Something along the lines of :

class ImageFactory
{
    public function build($image, $location)
    {
        $instance = new Image($image, $location);
        $instance->prepare();
        return $instance;
    }
}

The class would need some changes:

class Image
{

    protected $_image; // you were leaking abstraction
    protected $_extension;
    protected $_mime;
    protected $_size;
    protected $_location;
    protected $_description;

    public function __construct($image, $location)
    {
        $this->_image = $image;
        $this->_location = $location;
    }

    public function prepare()
    {
        $this->_extension = $this->getExtension();
        $this->_mime = $this->getMime();
        $this->_size = $this->getSize();
    }

   private functions fallow.....

}

Now when you need to create new object you do:

$factory = new ImageFactory;
$image = $factory->build( $file, '/uploads/' );

Of course the instance of ImageFactory can be reusable, and if all your images use the same $location, then you would pass that variable to factory at the initialization. And the factory would be able to "remember it" and pass to all the images it creates:

$factory = new ImageFactory('/uploads/');
$img1 = $factory->build( $file );
$img2 = $factory->build( $something_else );

This is actually how one should deal with creating multiple objects, which all need access to same DB connection instance.

Jeremy Harris · Accepted Answer · 2012-04-01 00:06:36Z

0

Yes, you can call methods from within the constructor. Remember that the __construct() magic method was implemented in PHP 5. Prior to that, you created a function named the same as your class which acted as your constructor so depending on your PHP version, that could be a problem.

Additionally, the function calls you are making, are they in the class or external? If they are inside the class you need to call them this way:

$this->_extension = $this->getExtension();

edited Apr 1, 2012 at 0:06

answered Mar 31, 2012 at 23:59

Jeremy Harris

24.7k13 gold badges84 silver badges133 bronze badges

Comments

Dumbo · Accepted Answer · 2012-04-01 00:08:23Z

0

You didnt specified what error you are expiriencing clearly. But try calling you class methods even inside the class using this keyword, otherwise it would not work:

public function __construct($image, $location)
{  
    $this->_image = $image;  
    $this->_location = $location;  
    $this->_extension = $this->getExtension();  
    $this->_mime = $this->getMime();  
    $this->_size = $this->getSize();  
}

Would be a better idea to post your code for the methods you wrote. There could be something wrong within them as well. Possibly forgetting to return a result or something...

edited Apr 1, 2012 at 0:08

answered Apr 1, 2012 at 0:02

Dumbo

14.2k56 gold badges193 silver badges294 bronze badges

Collectives™ on Stack Overflow

php oop constructor

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related