PHP: Database Connection Class - Won't Connect

Question

I'm having trouble with my DatabaseConnection class. I cannot seem to get $dbUser or $dbName variables to work for this connection class. I currently have to manually put the values in with quotes. Is there something I am doing wrong?

class DatabaseConnection {
    private $dbHost = "localhost";
    private $dbUser = "root";
    private $dbPass = "";
    private $dbName = "test";

    function __construct() {
        $connection = mysql_connect($dbHost, "root", $dbPass)
            or die("Could not connect to the database:<br />" . mysql_error());
        mysql_select_db("test", $connection) 
            or die("Database error:<br />" . mysql_error());
    }
}

If you have suggestions for improving my current class, by all means, let me know!

Gohn67 · Accepted Answer · 2012-03-28 04:29:28Z

2

Since this is a class, you have to access your class variables using $this->dbHost, $this->dbUser, etc instead of $dbHost, $dbUser. Php requires that you use $this->variableName for class variables.

EDIT:

Here's your code with the mysql_connect variables changed to access your class variables

class DatabaseConnection {
    private $dbHost = "localhost";
    private $dbUser = "root";
    private $dbPass = "";
    private $dbName = "test";

    function __construct() {
        $connection = mysql_connect($this->dbHost, $this->dbUser, $this->dbPass)
            or die("Could not connect to the database:<br />" . mysql_error());
        mysql_select_db("test", $connection) 
            or die("Database error:<br />" . mysql_error());
    }
}

edited Mar 28, 2012 at 4:29

answered Mar 28, 2012 at 4:22

Gohn67

10.7k2 gold badges32 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Aaron Over a year ago

Excellent, that makes sense, thank you. Another quick question, but is it right that I set those variables to private, or should they simply be var?

Gohn67 Over a year ago

Yes, private is the way to go. You want to make it so your class controls access to those variables.

Collectives™ on Stack Overflow

PHP: Database Connection Class - Won't Connect

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related