Ruby if else syntax

Question

I have an app where users can sign up with Facebook, in which case I take the Facebook image, or they can sign up using regular authentication, in which case they're uploading a photo using CarrierWave gem.

Because of some sort of conflict, I had to create a column in the database (:image)to store the url to the Facebook image, and then a different column (:dimage) to store the url for the image if they signed up using the non-facebook sign up.

So when it comes time to display the user, I'm checking to see if there's an :image, and, if not, then displaying the other :dimage.

However, I don't want to require them to upload an image, in which case, I want to display an anon image (here represented by the rails.png). However, the Rails.png isn't showing up (just a broken image path), so I'm assuming there's some sort of error with my if else syntax because the image_tag("rails.png") is taken straight from the api

 <% if user.image %>
 <%= image_tag user.image %>
 <% elsif user.dimage %>
 <%= image_tag user.dimage_url(:thumb).to_s %>
 <% else %>
 <%= image_tag("rails.png") %>
 <% end %>

The generated html on the rails.png

<img alt="Assets" src="/assets/">

Your logic is in the wrong place, you should have a simple image_thumb_url method on User that returns the appropriate src attribute. — mu is too short
– mu is too short, Commented Mar 27, 2012 at 4:19
Add a method called image_thumb_url to your User model, that method would have the if...else stuff and your ERB would just be <%= image_tag user.image_thumb_url %>. — mu is too short
– mu is too short, Commented Mar 28, 2012 at 3:30

kwarrick · Accepted Answer · 2012-03-27 04:07:27Z

4

Use the present? method to check if the attribute is not empty:

<% if user.image.present? %>
  <%= image_tag user.image %>
<% elsif user.dimage.present? %>
  <%= image_tag user.dimage_url(:thumb).to_s %>
<% else %>
  <%= image_tag("rails.png") %>
<% end %>

You'll save yourself a headache or two because in Ruby the only falsehoods are false and nil. This means that the empty string "" will actually return true.

answered Mar 27, 2012 at 4:07

kwarrick

6,2602 gold badges29 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chris · Accepted Answer · 2012-03-27 03:53:22Z

0

You need to look at look into user.image.nil? user.image.empty? and user.image.blank? depending on what you're using and apply the same to the rest of your conditional. You need to find out specifically what your looking for or the if else won't give you what you want. I would try empty first which checks if something is nil or is an empty string.

answered Mar 27, 2012 at 3:53

Chris

7564 silver badges11 bronze badges

Comments

Juan Guerrero · Accepted Answer · 2012-03-27 04:00:22Z

0

When you create a new rails application, rails stores its logo in PROJECT_PATH/app/assets/images folder. Could you check if that image exists?

edited Mar 27, 2012 at 4:00

answered Mar 27, 2012 at 3:54

Juan Guerrero

6134 silver badges9 bronze badges

1 Comment

Leahcim Over a year ago

I also tried it with this <%= image_tag("dl.dropbox.com/u/10328969/smiley.jpg")%> instead of the rails.png in assets/images but didn't work

Collectives™ on Stack Overflow

Ruby if else syntax

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related