Initialising fields inline or within constructor

Question

Stylistically is it better to initialise Java fields within a constructor or at the point where the field is declared? For example:

public class Foo {
  private final List<String> l;

  public Foo() {
    this.l = new LinkedList<String>();
  }
}

... or

public class Foo {
  private final List<String> l = new LinkedList<String>();
}

I have typically favoured the former as it seemed clearer. However, the latter obviously results in more compact code.

possible duplicate of Best Practice: Initialize class fields in constructor or at declaration? — Oliver Charlesworth
– Oliver Charlesworth, Commented Mar 21, 2012 at 11:23
The former one's good to me because, your list is initialized only when your object is created. — sgowd
– sgowd, Commented Mar 21, 2012 at 11:23

aioobe · Accepted Answer · 2012-03-21 11:23:18Z

4

My rule of thumb is:

Put it at the point of the declaration if

...it can (i.e. if it doesn't rely on constructor arguments for instance)
...it's value does not need any form of computation
...the value is the same regardless which constructor is used.

otherwise, put it in the constructor.

Usually I follow the official Java Coding Conventions strictly. In this particular case the convention doesn't say anything about it, so it's up to each programmer to decide. Which ever you pick however, you probably want to be consistent with your choice.

answered Mar 21, 2012 at 11:23

aioobe

423k115 gold badges831 silver badges844 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

hmjd · Accepted Answer · 2012-03-21 11:23:17Z

1

If you have more than one constructor then the initialisation (may) need to be repeated if it was not initialised at point of delcaration.

answered Mar 21, 2012 at 11:23

hmjd

122k21 gold badges216 silver badges259 bronze badges

Collectives™ on Stack Overflow

Initialising fields inline or within constructor

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related