Private variable accessed by private method in javascript

Question

function Cons(name) {
var pvar1="hi "+name;
sayhi = function() {
   alert(pvar1);
}
attEvents(){
$('#'+name).bind("click",sayhi);
}
}
var a = new Cons('name1');
var b = new Cons('name2');
var c = new Cons('name3');

Let us assume that name1, name2, name3 are all divs. Now, whatever div I click, I am always getting "hi name3". The private variable is having the last stored value in it irrespective of the div clicked. Any help is appreciated.

Thanks

Probably because sayhi is global and .bind("click",sayhi); is called some time after the three objects have been created. But to know for sure you would have to correct/clarify this statement: attEvents(){ $('#'+name).bind("click",sayhi);} What is it doing? — Felix Kling
– Felix Kling, Commented Mar 20, 2012 at 10:42
My mistake, attEvents will just attach the events to the div. It will be called at the end of Cons(). And yes sayhi was in global scope. Thanks for the help. Did not know that var should be used even when functions are defined. Thanks a lot :) — Gautham Renganathan
– Gautham Renganathan, Commented Mar 20, 2012 at 11:02

freakish · Accepted Answer · 2012-03-20 11:01:40Z

2

sayhi = function() {
   alert(pvar1);
}

If you define it without var keyword then it is defined as a global. Thus sayhi refers to the function defined as a last one. Use

var sayhi = function() {
   alert(pvar1);
}

or

var pvar1 = "hi "+name,
    sayhi = function() {
        alert(pvar1);
    };

Note the comma. Or true jQuery style

$('#'+name).bind("click", function() {
    alert(pvar1);
});

edited Mar 20, 2012 at 11:01

answered Mar 20, 2012 at 10:45

freakish

57k12 gold badges141 silver badges181 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Private variable accessed by private method in javascript

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related