PHP Repeating Print Statement

Question

I'm having an issue with a PHP print statement that repeats the output continuously for about 40 or 50 times, then stops. I thought it was supposed to print only one line. I'm still somewhat new to PHP, so I don't understand what I'm doing wrong. The code in question is located at the bottom of the snippet.

Thanks in advance.....

 <?php
$query = $_POST['query'];
find_files('.');

function find_files($seed) {
    if(! is_dir($seed)) return false;

    $files = array();
    $dirs = array($seed);

    while(NULL !== ($dir = array_pop($dirs))) {
        if($dh = opendir($dir)) {
            while( false !== ($file = readdir($dh))) {
                if($file == '.' || $file == '..') continue;
                $path = $dir . '/' . $file;
                if(is_dir($path)) { 
                    $dirs[] = $path; 
                } else { 
                    if(preg_match('/^.*\.(php[\d]?|js|txt)$/i', $path)) { 
                        check_files($path); 
                    }
                }
            }
            closedir($dh);
        }
    }
}

function check_files($this_file) {
    $query = $_POST['query'];
    $str_to_find = $query;

    if ((isset($str_to_find)) && (empty($str_to_find))) {
        print '<p>Your search produced no results</p>';
    } else {
        if(!($content = file_get_contents($this_file))) { 
            echo("<p>Could not check $this_file</p>\n"); 
        } else { 
            if(stristr($content, $str_to_find)) { 
                echo("<p>$this_file -> contains $str_to_find</p>\n"); 
            }
        }
        unset($content);
    }
}
?>

Perhaps you are calling Checkfiles repeatedly (hinted at by spencercw)? ->check_files($path); It's in a while() loop, so it will print every time that sections loops. — user978122
– user978122, Commented Feb 24, 2012 at 23:36
user978122, thanks for the info. that makes sense.....is there a way to prevent the echo statement from par-taking in this "while" statement? — Rob Myrick
– Rob Myrick, Commented Feb 24, 2012 at 23:40
@user978122 Just move it outside of the function. See my answer. — spencercw
– spencercw, Commented Feb 24, 2012 at 23:43

spencercw · Accepted Answer · 2012-02-24 23:36:09Z

2

'Your search produced no results' will be printed out once for every file that your loop sees. You should do the check before you call find_files():

if (!isset($str_to_find) || empty($str_to_find)) {
    print '<p>Your search produced no results</p>';
} else {
    find_files('.');
}

You can then remove that bit of code from check_files().

answered Feb 24, 2012 at 23:36

spencercw

3,35817 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

swayne · Accepted Answer · 2012-02-24 23:38:22Z

0

You have the print statement inside of the check_files() function, which is being called from inside your while... loop. So, yes, it's going to be executed each time that loop executes and the conditions match.

answered Feb 24, 2012 at 23:38

swayne

843 bronze badges

Comments

Dion · Accepted Answer · 2012-02-24 23:40:54Z

0

By !== you maybe meant !=?

answered Feb 24, 2012 at 23:40

Dion

3,34525 silver badges40 bronze badges

1 Comment

spencercw Over a year ago

=== just means 'exactly equals' and doesn't do things like converting strings to ints. It's generally a good idea to always use === and !==.

Collectives™ on Stack Overflow

PHP Repeating Print Statement

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related