Insert array data into database

Question

I'm trying to insert array into database. Why don't this work?

$array_zone = array();
$array_data = array();
while($row = mysql_fetch_array($keputusan1)){
$array_zone[] = $row['zone'];
$array_data[] = $row['data'];
}

echo "<pre>";
print_r($array_zone);
echo "<br>";
print_r($array_data);
echo "</pre>";

$list_zone = implode(",", $array_zone);
$list_data = implode(",", $array_data);

for($i = 0; $i < 4; $i++)
{
mysql_query("INSERT INTO `db`.`table1` (`id`, `domain`) VALUES ('$list_zone', '$list_data')");
}

Array output before implode:

Array
(
    [0] => 270
    [1] => 270
    [2] => 255
    [3] => 255
)

Array
(
    [0] => ok.com.
    [1] => lo.com.
    [2] => i.com.
    [3] => k.com.
)

Result I'm getting: phpmyadmin

0 key should go with data in 0 key and 1 key should go with data in 1 key and so on... Help me please. Thank you.

You seem to be using $list_zone and $list_data instead of $array_zone and $array_data — Pieter Bos
– Pieter Bos, Commented Feb 19, 2012 at 9:33

Shiplu Mokaddim · Accepted Answer · 2012-02-19 09:50:13Z

4

You can use INSERT ... SELECT. The result returned in $keputusan1 is a SELECT query. And it certainly returns zone and data columns. Say the query is SELECT zone, data, columns ... FROM tbl1.

If you use INSERT ... SELECT the new query would be

INSERT INTO `db`.`table1` (`id`, `domain`) SELECT zone, data FROM tbl1";

This will SELECT first then INSERT it in one shot.

The problems with your code are

4 SQL statements. It should be 1.
You should use $array_zone and $array_data instead of $list_zone and $list_data if for loop is used. But it should not be as of step 1.

edited Feb 19, 2012 at 9:50

answered Feb 19, 2012 at 9:43

Shiplu Mokaddim

57.8k20 gold badges147 silver badges193 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

sg552 Over a year ago

Yes. This solve it and much efficient. I learned new thing today. Thank you :)

mindandmedia · Accepted Answer · 2012-02-19 09:46:28Z

2

It seems to me, that you just forgot to use the loop-index ($i) within the loop to access the arrays elements:

#!/usr/bin/php
<?php
 $array_zone = array('a','b','c','d');
 $array_data = array('1','2','3','4');

print_r($array_zone);
print_r($array_data);

for($i = 0; $i < count($array_zone); $i++)
{
  echo("INSERT INTO `db`.`table1` (`id`, `domain`) VALUES ('$array_zone[$i]', '$array_data[$i]')\n");
}
?>

Now replace that echo with your mysql_query call and remove the '\n' at the end...

answered Feb 19, 2012 at 9:46

mindandmedia

6,8551 gold badge26 silver badges33 bronze badges

1 Comment

sg552 Over a year ago

Oh I can only choose 1 correct answer. You answer did solve my problem but other user gave me other approach that is much efficient. Anyway I really appreciate your help. Thank you :)

alexis · Accepted Answer · 2012-02-19 09:32:40Z

1

Your list_zone (really array_zone) is enclosed in a single set of single quotes, so you're passing one long string. And you're doing it four times. Pass it one pair of values at a time.

answered Feb 19, 2012 at 9:32

alexis

50.4k18 gold badges107 silver badges172 bronze badges

Comments

Eduard7 · Accepted Answer · 2012-02-19 09:42:28Z

0

Are you sure you want to do this in that way? Probably a good idea to try the serialize() function instead of the implode. http://php.net/manual/en/function.serialize.php

Maybe an even better idea to use JSON for this task. http://php.net/manual/en/function.json-encode.php

answered Feb 19, 2012 at 9:42

Eduard7

7467 silver badges21 bronze badges

Collectives™ on Stack Overflow

Insert array data into database

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related