PHP + JavaScript PopUp Windows

Question

On my page, the following function has been created:

<SCRIPT language="javascript" type="text/javascript">
    function popModData( modName )
    {
        var url = "./modList.php?mod=" + modName;
        newWindow = window.open( url, modName, 'width=500,height=500,scrollbars=no,resizable=no,toolbar=no,directories=no,location=no,menubar=no,status=no,left=0,top=0');
        if( window.focus ) { newWindow.focus() }
        return false;
    }
</SCRIPT>

And, the page itself is modList.php which loads data of different game-mods from SQL table. I want each of the game-mod name clickable, so that a pop-up opens. I am using this in the php page generation:

while( $modTable = mysql_fetch_array( $getMod ) )
{
    $colour = ( $i % 2 )? "#99EECC" : "CCDDFF";
    echo "\t\t\t<tr bgcolor='$colour'>";
    echo "\n\t\t\t\t<td>" . $i++ . ".</td>";
    echo "\n\t\t\t\t<td onclick='return popModData($modTable[Name]);'>$modTable[Name]</td>";
    echo "\n\t\t\t\t<td>$modTable[From]</td>\n\t\t\t</tr>";
}

Upto this, no trouble is faced. Now, the trouble is pop-up window opens for the first entry in the table, but not for any of the other 516 values.

I thought of having another file to process the mod name( for eg. modData.php ) but, the problem is still there.

Please help. If anything is missing there, please mention, and I will try to put it up too!

^ this. And: where do you initialize the $i counter? How's the sql query? — Damien Pirsy
– Damien Pirsy, Commented Feb 5, 2012 at 8:58

vinczemarton · Accepted Answer · 2012-02-05 09:29:28Z

2

Surround the names with " " as you need javascript to parse them as strings.

Like this:

while( $modTable = mysql_fetch_array( $getMod ) )
{
    $colour = ( $i % 2 )? "#99EECC" : "CCDDFF";
    echo "\t\t\t<tr bgcolor='$colour'>";
    echo "\n\t\t\t\t<td>" . $i++ . ".</td>";
    echo "\n\t\t\t\t<td onclick='return popModData(\"$modTable[Name]\");'>$modTable[Name]</td>";
    echo "\n\t\t\t\t<td>$modTable[From]</td>\n\t\t\t</tr>";
}

answered Feb 5, 2012 at 9:29

vinczemarton

8,2267 gold badges59 silver badges91 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

hjpotter92 Over a year ago

Thanks! Dunno why it worked now. I tried putting it like return popModData('$modTable[Name]'); and return popModData(\'$modTable[Name]\'); too.

vinczemarton Over a year ago

You are already inside an onclick='...' dont use ' inside ' as it makes no difference in js if you use ' or ", so you can always use he other. Also php possibly ate the \ anyway.

Collectives™ on Stack Overflow

PHP + JavaScript PopUp Windows

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related