using php preg_replace to change html link's href attribute

Question

I'm trying to replace all link href's in a large string with a different URL. With the following code It seems to replace only the 2nd link leaving the first one intact, can someone help me out?

$string_of_text = '<a href="http://www.php.net/">PHP</a> <a href="http://www.apache.org/">Apache</a>';
echo preg_replace('/<a(.*)href="(.*)"(.*)>/','<a$1href="javascript:alert(\'Test\');"$3>',$string_of_text);

Please fix your question title to describe the question. Take a look at all the rubbish in the "Related" pane on the right of my comment, and don't add to it. :) — Lightness Races in Orbit
– Lightness Races in Orbit, Commented Jan 30, 2012 at 0:40
Lol, I'm sorry Lightness Races in Orbit, I can't see an edit button anywhere however I'll be sure my next question is much more detailed — Joe
– Joe, Commented Jan 30, 2012 at 0:45

Joop Eggen · Accepted Answer · 2012-01-30 00:52:42Z

16

Instead of any char . use any not (^) quote [^"]

echo preg_replace('/<a(.*)href="([^"]*)"(.*)>/','<a$1href="javascript:alert(\'Test\');"$3>',$string_of_text);

edited Jan 30, 2012 at 0:52

answered Jan 30, 2012 at 0:39

Joop Eggen

110k8 gold badges89 silver badges142 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Haris Over a year ago

@JoopEggen , i have nearly similar problem. i have an array of links containing id params, and another array of ids. i want to replace all link's href attribute of the first array that have the same ids in the second array.... sorry for my grammar, if incorrect!!!

Joop Eggen Over a year ago

@user8009 (no sorry neeeded - hey, I am esperantist: English = gcd, Esperanto = lcm) Maybe put a question in SO with some more details. There exists a regex replace applying a function for replacement: php.net/manual/en/function.preg-replace-callback.php maybe that could be used in your case.

Howdy_McGee · Accepted Answer · 2018-04-23 15:28:16Z

6

Just use the greedy operator in your regex like this:

'/<a(.*?)href="(.*?)"(.*?)>/'

edited Apr 23, 2018 at 15:28

Howdy_McGee

10.7k31 gold badges117 silver badges191 bronze badges

answered Jan 30, 2012 at 0:39

Aurelio De Rosa

22.2k8 gold badges51 silver badges71 bronze badges

Comments

Yash · Accepted Answer · 2013-10-31 15:20:51Z

0

Slight modifications to Aurelio De Rosa's answer:

'/<a(.*?)href=(["\'])(.*?)\\2(.*?)>/i'

answered Oct 31, 2013 at 15:20

Yash

9199 silver badges25 bronze badges

Collectives™ on Stack Overflow

using php preg_replace to change html link's href attribute

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related