Using variable in a regex

Question

say i have the following variables:

myId; //Email_PDF
currentHoverOnItem; //Email_PDF_english of Email_PDF_Dutch or ...

So the first value is "Email_PDF" and the second is "Email_PDF_english". What i want i when currentHoverOnItem contains myId, then something can be executed. This is what i have so far:

var pattern = new RegExp("^/"+myId+"/$");

if (currentHoverOnItem.match(pattern))
{
    //Do something
}

Is this the right way to use the regex? It should match part of the string, there can be text before or after the match.

Providing that currentHoverOnItem returns a string then there is nothing wrong with what you are doing. Except the $ in the pattern means that you won't get a match with values you have given in the example. — Dan Iveson
– Dan Iveson, Commented Jan 25, 2012 at 15:26
Look at stackoverflow.com/questions/1789945/javascript-string-contains — hop
– hop, Commented Jan 25, 2012 at 15:41

georg · Accepted Answer · 2012-01-25 15:26:22Z

1

Is this the right way to use the regex?

No! Regexes are for patterns, not for literal strings. Use indexOf

if (currentHoverOnItem.indexOf(myId) >= 0)
{
    //Do something
}

answered Jan 25, 2012 at 15:26

georg

216k57 gold badges324 silver badges401 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ShankarSangoli · Accepted Answer · 2012-01-25 15:27:00Z

0

Try this

var pattern = new RegExp(myId, "g");

if (currentHoverOnItem.match(pattern))
{
    //Do something
}

answered Jan 25, 2012 at 15:27

ShankarSangoli

69.9k13 gold badges96 silver badges124 bronze badges

Comments

ExternalUse · Accepted Answer · 2012-01-25 15:27:03Z

0

Your pattern is "anchored", meaning that ^ and $ specifiy begin and end of your string. To match "Email_PDF_english" in an anchored pattern you could use ^Email_PDF_(.*)$, but it won't match if your string is longer, as your comment suggests.

If it's not anchored you could test for a blank following the Email_PDF_... string, ie Email_PDF_([^\s]*)\s+

answered Jan 25, 2012 at 15:27

ExternalUse

2,0752 gold badges26 silver badges37 bronze badges

Comments

hop · Accepted Answer · 2012-01-25 15:34:40Z

0

You need not use a reg_exp here. Using indexOf will do the trick for you

if(currentHoverOnItem.indexOf(myId) != -1)
{
    //Do something
}

answered Jan 25, 2012 at 15:34

hop

2,55811 gold badges40 silver badges56 bronze badges

Collectives™ on Stack Overflow

Using variable in a regex

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related