rails 3 - escaping partial's generated html in javascript response

Question

I am trying to do a simple thing where:

_flash.js.erb:

$("#alerts").append("<%=j render :template => "shared/_flash.html.erb" %>");

Note the <%=j... which escapes the javascript.

_flash.html.erb:

<% flash.each do |key, value| %>
  <div class="alert-message top <%= "#{key}" %> fade in" data-alert="alert">
    <a class="close" href="#">x</a>
    <p><%=j value %></p>
  </div>
<% end %>

When _flash.js.erb is called, however, something like the following is appended:

$("#alerts").append("  \u003Cdiv class=alert-message top warning fade in data-alert=alert\u003E
    \u003Ca class=close href=#\u003Ex\u003C/a\u003E
    \u003Cp\u003ELooks like you have already linked with Facebook.\u003C/p\u003E
  \u003C/div\u003E
");

Without the javascript escaping, the response is like this:

$("#alerts").append("  <div class="alert-message top warning fade in" data-alert="alert">
    <a class="close" href="#">x</a>
    <p>Looks like you have already linked with Facebook.</p>
  </div>
");

In the first response, TOO much stuff is escaped. In the second response, nothing is escaped and the double quotes mess things up.

What is the recommended way in rails 3 to achieve the above in a robust fashion?

So turns out that using escape_javascript(...) instead of <%=j .. %> yields the desired results. Weird - thought they were the same thing. I guess I will have to settle with more verbosity. Any less verbose alternatives or a way to make <%=j ... %> work? — deruse
– deruse, Commented Jan 21, 2012 at 23:23

Dave Newton · Accepted Answer · 2012-01-21 23:28:59Z

3

Use escape_javascript instead; you're JSON-escaping it.

You could alias something the same way j is an alias to json_escape; it's just a helper.

edited Jan 21, 2012 at 23:28

answered Jan 21, 2012 at 23:23

Dave Newton

161k27 gold badges263 silver badges310 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

deruse Over a year ago

Someone needs to fix these docs then --api.rubyonrails.org/classes/ActionView/Helpers/…

Collectives™ on Stack Overflow

rails 3 - escaping partial's generated html in javascript response

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related