Sending parameters to a javascript function from HTML

Question

This code works fine to send one parameter to a javascript function, but when I add a second parameter, it doesn't. onclick="open_livemass(\"Devotion\",'+devotion_channel.idx+');". Is this the right way to send these parameters to the function? One parameter is static. The other, devotion_channel.idx, is determined by the javascript that creates the HTML.

show_devotion_alert = '<span style="cursor:pointer;"'+
  'onclick="open_livemass(\"Devotion\",'+devotion_channel.idx+');"><br/>'+
  devotion_name+' '+time_info+'<br/>('+devotion_channel.name+')</span>';

$('#Devotion_alert').html(show_devotion_alert);

Adam Rackis · Accepted Answer · 2012-01-17 18:30:31Z

2

You're mixing quote styles

'onclick="open_livemass(\'Devotion\',' + devotion_channel.idx + ');"

But why not do this:

show_devotion_alert = '<span id="newSP" style="cursor:pointer;"><br/>'+
  devotion_name+' '+time_info+'<br/>('+devotion_channel.name+')</span>';

$('#Devotion_alert').html(show_devotion_alert);

$("#newSP").click(function() {
    open_livemass("Devotion", devotion_channel.idx);
});

Or better yet:

show_devotion_alert = $('<span />').css("cursor", "pointer").html("<br/>" +
  devotion_name + ' ' + time_info + '<br/>(' + devotion_channel.name + ')');

show_devotion_alert.click(function() {
    open_livemass("Devotion", devotion_channel.idx);
});

$('#Devotion_alert').html(show_devotion_alert);

edited Jan 17, 2012 at 18:30

answered Jan 17, 2012 at 18:22

Adam Rackis

83.5k57 gold badges281 silver badges402 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Alex Wayne Over a year ago

Direct event binding is always better than encoding an onclick attribute in the HTML string.

user823527 Over a year ago

Looks like the problem was the , was in the wrong place in the quotes. Several other people had suggestions about using the click event. That makes sense.

Adam Rackis Over a year ago

@user823527 - yeah - trying to insert click handlers like that is painful -- jQuery makes it much easier.

Esailija · Accepted Answer · 2012-01-17 18:31:21Z

1

$('#Devotion_alert').empty().append( $( "<span>", {
    css: {
        cursor: "pointer"
    },

    html: "<br />" + devotion_name + " " + time_info + "<br />",

    click: $.proxy( open_livemass, this, "Devotion", devotion_channel.idx )
}));

answered Jan 17, 2012 at 18:31

Esailija

140k24 gold badges280 silver badges328 bronze badges

1 Comment

user823527 Over a year ago

Good tip for having css, html and event neatly specified when creating new elements.

j08691 · Accepted Answer · 2012-01-17 18:20:33Z

0

Try this:

show_devotion_alert = "<span style=\"cursor:pointer;\" onclick=\"open_livemass(\"Devotion\","+devotion_channel.idx+");\"><br />"+devotion_name+" "+time_info+"<br />("+devotion_channel.name+")</span>";

answered Jan 17, 2012 at 18:20

j08691

208k33 gold badges269 silver badges281 bronze badges

Comments

ShankarSangoli · Accepted Answer · 2012-01-17 18:27:07Z

0

I would suggest you to try this.

var show_devotion_alert = '<span style="cursor:pointer;"><br />' 
                        + devotion_name + ' ' + time_info + '<br />('
                        + devotion_channel.name + ')<span/>';


$('#Devotion_alert').html(show_devotion_alert)
.find('span')
.click(function(){
    open_livemass('Devotion', devotion_channel.idx);
});

answered Jan 17, 2012 at 18:27

ShankarSangoli

69.9k13 gold badges96 silver badges124 bronze badges

1 Comment

user823527 Over a year ago

Looks like specifying the click separately is a good way to fix the problem.

Collectives™ on Stack Overflow

Sending parameters to a javascript function from HTML

4 Answers 4

3 Comments

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related