javascript function not working correctly

Question

I have the following simple javascript function to slide an object up and down.

When I first click it should slide down which it should do and alerts with true which it should do. However on the second click I want it to slideup however it detects firstclick to be true again. Any ideas

<script type="text/javascript">
var firstclick = true;


function slidedown(){

    if (firstclick = true){


        $( '#rerooftext' ).slideDown(500);  

        alert(firstclick);
        firstclick = false;
    }

    else {
        $('#rerooftext').slideUp(500);
        $firstclick = true;
    }
}





</script>

check your browsers error console you will get your error

user1140574
– user1140574

2012-01-17 05:22:30 +00:00
Commented Jan 17, 2012 at 5:22 — user1140574
– user1140574, Commented Jan 17, 2012 at 5:22

gdoron · Accepted Answer · 2012-01-17 06:42:15Z

3

firstclick = true should be firstclick === true

edited Jan 17, 2012 at 6:42

gdoron

151k59 gold badges302 silver badges376 bronze badges

answered Jan 17, 2012 at 5:16

Skyrim

8655 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Skyrim Over a year ago

also $firstclick = true; should be firstclick = true;

Skyrim Over a year ago

btw, you should checkout slideToggle() in jQuery

Clay Garrett · Accepted Answer · 2012-01-17 05:17:57Z

0

Where you have:

if (firstclick = true){

It should be:

if (firstclick == true){

You're setting firstclick to be true instead of testing if it is.

answered Jan 17, 2012 at 5:17

Clay Garrett

1,0238 silver badges11 bronze badges

Comments

Sudhir Bastakoti · Accepted Answer · 2012-01-17 05:18:10Z

0


function slidedown(){

    if (firstclick == true){


        $( '#rerooftext' ).slideDown(500);  

        alert(firstclick);
        firstclick = false;
    }

    else {
        $('#rerooftext').slideUp(500);
        firstclick = true;
    }
}

answered Jan 17, 2012 at 5:18

Sudhir Bastakoti

100k15 gold badges163 silver badges169 bronze badges

Comments

Selvakumar Ponnusamy · Accepted Answer · 2012-01-17 05:18:45Z

0

The statement if (firstclick = true) is wrong in your code. This will return true always. Please change the statement to if(firstclick)

answered Jan 17, 2012 at 5:18

Selvakumar Ponnusamy

5,6238 gold badges46 silver badges90 bronze badges

Comments

falinsky · Accepted Answer · 2017-07-10 21:51:54Z

0

firstly delete the $ sign before firstclick in the else statement

edited Jul 10, 2017 at 21:51

answered Jan 17, 2012 at 5:17

falinsky

7,4454 gold badges34 silver badges59 bronze badges

Collectives™ on Stack Overflow

javascript function not working correctly

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related