C++ for-loop structure with multiple variable initialization

Question

On the 2nd for-loop, I get the following error from gcc:

error: expected unqualified-id before 'int'

I'm not sure what I'm missing. I've looked over documentation for how a for-loop should look and I'm still confused. What's wrong here?

#include <iostream>
#include <vector>

int main() { 
std::vector<int> values; 

for (int i = 0; i < 20; i++) { 
  values.push_back(i); 
}   

std::cout << "Reading values from 'std::vector values'" << std::endl;
for (int i = 0, int col = 0; i < values.size(); i++, col++) {
  if (col > 10) { std::cout << std::endl; col == 0; }
  std::endl << values[i] << ' ';
  }
}

jweyrich · Accepted Answer · 2012-01-09 04:22:56Z

16

Try without the int before col.

for (int i = 0, col = 0; i < values.size(); i++, col++)

answered Jan 9, 2012 at 4:22

jweyrich

32.5k5 gold badges70 silver badges101 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

jdphenix Over a year ago

Thank you - I didn't notice this at all.

Chaitanya Over a year ago

Can we perform logical operation between the two conditions pertaining to the variables i and j in placeholder for condition in the for loop?

Jerry Coffin · Accepted Answer · 2012-01-09 04:25:48Z

7

Others have already told you how to fix the problem you've noticed. On a rather different note, in this:

if (col > 10) { std::cout << std::endl; col == 0; }

It seems nearly certain that the last statement here: col==0; is really intended to be col=0;.

answered Jan 9, 2012 at 4:25

Jerry Coffin

494k83 gold badges656 silver badges1.2k bronze badges

1 Comment

jdphenix Over a year ago

That would be true - this was a simple test case I put together for the question. Good catch

Chethan Ravindranath · Accepted Answer · 2012-01-09 04:23:01Z

3

This should fix it

for (int i = 0, col = 0; i < values.size(); i++, col++) {
  if (col > 10) { std::cout << std::endl; col == 0; }
  std::endl << values[i] << ' ';
  }
}

A variable definition goes like this

datatype variable_name[=init_value][,variable_name[=init_value]]*;

answered Jan 9, 2012 at 4:23

Chethan Ravindranath

2,0612 gold badges19 silver badges28 bronze badges

2 Comments

James McNellis Over a year ago

The last sentence is not really true. For example, the following is valid: int w, *x, (*y)(int, int), z;

Chethan Ravindranath Over a year ago

I agree! I couldn't find the c++ standards' definition of variable declaration. Hence have given an abstract representation of a var declaration. here variable name doesn't strictly confirm to [a-zA-Z][a-zA-Z0-9]*. It can also mean *x, e.g. int w = 10, *x = NULL; Thanks for clarifying ! :)

Kalpesh Patel · Accepted Answer · 2012-01-09 04:32:31Z

2

Don't declare int after comma use,

for (int i = 0,col = 0; i < values.size(); i++, col++) {
  if (col > 10) { std::cout << std::endl; col == 0; }
  std::endl << values[i] << ' ';
  }
}

answered Jan 9, 2012 at 4:32

Kalpesh Patel

2,8202 gold badges28 silver badges54 bronze badges

Comments

def · Accepted Answer · 2017-02-10 17:44:48Z

1

This is akin to a regular multiple variables declaration/initialization in one line using a comma operator. You can do this:

int a = 1, b = 2;

declaring 2 ints. But not this:

int a = 1, int b = 2;   //ERROR

answered Feb 10, 2017 at 17:44

def

5694 silver badges21 bronze badges

Collectives™ on Stack Overflow

C++ for-loop structure with multiple variable initialization

5 Answers 5

2 Comments

1 Comment

2 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

1 Comment

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related