Comparing strings in mysql

Question

I am trying to compare urls in mysql but the query returns results matching any url.

Here is my query.

SELECT
  a.comment_ID, 
  a.comment_post_ID, 
  a.comment_content, 
  a.comment_date_gmt,  
  a.comment_author_url, 
  b.post_title, b.ID
 FROM 
   `wp_comments` a, 
   `wp_posts` b
 WHERE 
   a.comment_post_ID = b.ID
  AND 
   ('a.comment_author_email' = '$email'
   OR 
    'a.comment_author_url' = '$url')
  AND a.comment_approved = 1
 GROUP BY a.comment_ID
 ORDER BY a.comment_ID DESC

Thanks!

edit: full query

Consider revising this condition AND ('a.comment_author_email' = '$email' OR 'a.comment_author_url' = '$url') This returns true for either the author's email or the URL provided. What values are you passing? — dkulkarni
– dkulkarni, Commented Jan 5, 2012 at 10:31
if possible, send us this query with values and not variables, will make it easier to help =) — user745235
– user745235, Commented Jan 5, 2012 at 10:36

Khaja Minhajuddin · Accepted Answer · 2012-01-05 11:40:54Z

2

In your query, make sure you replace all the ' (single quote) characters with the ` (backtick) character.

edited Jan 5, 2012 at 11:40

Khaja Minhajuddin

6,7517 gold badges49 silver badges47 bronze badges

answered Jan 5, 2012 at 10:33

PhotoPaul

436 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

xkeshav · Accepted Answer · 2012-01-05 11:22:15Z

0

Tips:

Remove ' around php variable
Write backticks ` around table attributes instead of '
may be use of INNER JOIN can make thing easier

TRY this

$qry = " SELECT { watever} FROM  `wp_comments` a,
         INNER JOIN  `wp_posts` b ON `a`.`comment_post_ID` = `b`.`ID`
         WHERE
              `a`.`comment_author_email` = '".$email."'   
          OR  `a`.`comment_author_url` ='". $url."'     
         GROUP BY `a`.`comment_ID`
         ORDER BY `a`.`comment_ID` DESC ";

edited Jan 5, 2012 at 11:22

answered Jan 5, 2012 at 11:10

xkeshav

54.2k47 gold badges183 silver badges255 bronze badges

1 Comment

Shannon Hyland Over a year ago

Same result. Just returns any rows with a url in the comment_author_url :/

Collectives™ on Stack Overflow

Comparing strings in mysql

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related