Javascript objects and syntax

Question

I have an array called gallery_list:

var gallery_list = ["profile.cfm", "explore.cfm", "list.cfm", "lesson.cfm", "class.cfm", "deploy_to_class.cfm"];

When I write the following, it works:

$.fancybox([
            { 'href' : gallery_list[0],
            'type' : 'iframe' },
            { 'href' : gallery_list[1],
            'type' : 'iframe' },
            { 'href' : gallery_list[2],
            'type' : 'iframe' },
            { 'href' : gallery_list[3],
            'type' : 'iframe' },
            { 'href' : gallery_list[4],
            'type' : 'iframe' },
            { 'href' : gallery_list[5],
            'type' : 'iframe' },

        ]);

But if I try to do something like below, it does not work:

var data = new Array();
        for (i = 0; i < gallery_list.length, i++) {
                var obj = {
                    'href' : gallery_list[i],
                    'type' : 'iframe'   
                }
                data.push(obj);
        }

$.fancybox([
            data
        ]);

Can anyone provide any insight? Clearly I am getting something wrong with my data structures but I'm not sure what it is...

It's a good practice to create arrays as var data = []; instead of using new Array(). Check stackoverflow.com/a/1273936/275442 — julioolvr
– julioolvr, Commented Jan 4, 2012 at 17:39

Dave Newton · Accepted Answer · 2012-01-04 17:34:46Z

5

Your second example is an array inside an array. Instead:

$.fancybox(data);

answered Jan 4, 2012 at 17:34

Dave Newton

161k27 gold badges263 silver badges310 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Adhip Gupta · Accepted Answer · 2012-01-04 17:35:33Z

4

Can you try something like

$.fancybox( data );

answered Jan 4, 2012 at 17:35

Adhip Gupta

7,1838 gold badges36 silver badges46 bronze badges

Comments

Dexygen · Accepted Answer · 2012-01-04 19:23:38Z

0

$.fancybox([
            data
        ]);

Is redundant, data is already an array. [] is the operator for creating an array literal, so what you've done above is created an array, where the data array you've already constructed, is the first and only element.

As others have suggested what you want is the following:

$.fancybox(data);

To add a bit though, I think perhaps you would have avoided your mis-understanding had you initialized your "data" variable as follows:

var data = []; //instead of "new Array()"
for (i = 0; i < gallery_list.length, i++) {
    //etcetera

edited Jan 4, 2012 at 19:23

answered Jan 4, 2012 at 17:38

Dexygen

12.6k13 gold badges87 silver badges154 bronze badges

Collectives™ on Stack Overflow

Javascript objects and syntax

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related