Initializing an array of strings with a value that is not constant

Question

I have the following scenario:

char *value1 = decrypt(somestring);
char *value2 = decrypt(somethingelse);
static char *theValues[2] = {value1, value2};

This of course causes an error initializer is not a constant. the function decrypt() decrypts a value from the user's config file and returns a char*. I then have a for-loop that will check each value of theValues and compare it to a list of search strings.

If I remove the initialization and then try to copy value1 and value2 to theValues it crashes because I haven't allocated memory. I could go and malloc it and then copy the contents of value1, etc into the array, however I don't have 2 values like in the example above, I have 50.

Is there a way to initialize theValues without having to malloc each element on the array and manually copy the value after the decryption?

Thanks.

"If I remove the initialization and then try to copy value1 and value2 to theValues it crashes because I haven't allocated memory." Can you show us how you did this? This should work. — Mysticial
– Mysticial, Commented Dec 27, 2011 at 18:37

Basile Starynkevitch · Accepted Answer · 2011-12-27 18:38:30Z

1

You could declare your array

  static char *theValues[2];

Then it has two null pointers, since it is static; and you can fill it with e.g.

  if (!thevalues[0]) 
      thevalues[0] = decrypt(somestring);
  if (!thevalues[1])
      thevalues[1] = decrypt(somethingelse);

The tests ensure that (assuming decrypt don't return a null pointer) the initialization happens once. When the same containing function is called again, only the tests are re-executed, not the initialization.

answered Dec 27, 2011 at 18:38

Basile Starynkevitch

231k18 gold badges322 silver badges578 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mr Aleph Over a year ago

That did it. I was trying to strcpy each one as opposed to copying the points. Great, thanks.

Doug Currie · Accepted Answer · 2011-12-27 18:38:05Z

1

static char *theValues[2];

theValues[1] = decrypt(somestring);
theValues[2] = decrypt(somethingelse);

answered Dec 27, 2011 at 18:38

Doug Currie

41.4k1 gold badge103 silver badges121 bronze badges

Collectives™ on Stack Overflow

Initializing an array of strings with a value that is not constant

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related