Assigning array variables in Javascript

Question

I am having a small issue with variable assignment. For some reason my line variable doesn't properly assign.

var records = new Array();
var recid = -5
var subrecid = 6495;
var line = new Array();
line['recid'] = recid;
line['subrecid'] = subrecid;
if (subrecid > 0) records.push(line);

Actually, it does. Instead of checking what you think is the solution, can you provide a jsFiddle showing the error? — Ry-
– Ry- ♦, Commented Dec 24, 2011 at 22:17
How do you know it doesn't "assign"? What result are you expecting to get that you aren't getting? — Gareth
– Gareth, Commented Dec 24, 2011 at 22:17
mind you that javascript does NOT have associative arrays. You can use the 1line['syntax'] because you are actually calling an object there, but there is associative array in javascript. It might be the fact you just init it as an array? — Nanne
– Nanne, Commented Dec 24, 2011 at 22:20
JavaScript doesn't need arrays for that, by the way; there's no such thing as a hash or associative array. You can use var line = {}; line.recid = recid; line.subrecid = subrecid; instead. — Ry-
– Ry- ♦, Commented Dec 24, 2011 at 22:22

Matt Ball · Accepted Answer · 2011-12-24 22:27:53Z

4

Don't use an array for non-integer indexing. Use an object. Also, it's generally better to use [] instead of new Array(). Oh yeah, and there's a line missing a semicolon.

var records = [];
var recid = -5;
var subrecid = 6495;
var line = {}; // object, not array
line.recid = recid;
line.subrecid = subrecid;
if (subrecid > 0) records.push(line);

Even more concise:

var records = [];
var recid = -5;
var subrecid = 6495;
var line = {
    recid: recid,
    subrecid: subrecid
};
if (subrecid) records.push(line);

edited Dec 24, 2011 at 22:27

answered Dec 24, 2011 at 22:19

Matt Ball

361k102 gold badges655 silver badges725 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

RobG Over a year ago

Ha! You did that while I was typing. I considered the different test but it's not clear whether or how subrecid is being modified so it might become -ve at some point.

Ry- · Accepted Answer · 2011-12-24 22:35:22Z

2

Matt's answer is fine, but you could take greater advantage of object literal syntax:

var records = [];
var line = {recid: -5, subrecid: 6495 };

if (line.subrecid > 0) records.push(line);

edited Dec 24, 2011 at 22:35

Ry-♦

226k56 gold badges496 silver badges504 bronze badges

answered Dec 24, 2011 at 22:29

RobG

148k32 gold badges180 silver badges216 bronze badges

1 Comment

Jason Sundram Over a year ago

or for maximum terseness: var records = [{recid: -5, subrecid: 6495 }];

Kirsteins · Accepted Answer · 2015-08-25 11:05:55Z

-1

var val1=$('#Accountstype_account_c').val();

edited Aug 25, 2015 at 11:05

Kirsteins

27.3k8 gold badges79 silver badges78 bronze badges

answered Aug 25, 2015 at 7:29

jack

1

1 Comment

Trisha Over a year ago

It would be helpful to add a bit more explanation as to why this is a solution.

Collectives™ on Stack Overflow

Assigning array variables in Javascript

3 Answers 3

1 Comment

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related