Android: Put SQL data into array

Question

i have two mehods, one to collect SQL data and one to put it into a listview.. it seems i can't get the array to form correctly in the SQL part so that it can be passed tot the listview.

SQL act:

public String[] getDataInArray() { // get data for list and return in array form
    // TODO Auto-generated method stub

    String[] columms = new String[]{ KEY_ROWID, KEY_NAME};
    String[] return_colums = null;

    Cursor c = currentdatabase.query(DATABASE_TABLE, columms, null, null, null, null, null);

    int iRow = c.getColumnIndex(KEY_ROWID);
    int iName = c.getColumnIndex(KEY_NAME);
    int rowcount = 0;

    for(c.moveToFirst(); !c.isAfterLast(); c.moveToNext())
    {
        return_colums[rowcount] = c.getString(iName) + "," + c.getString(iRow);
        rowcount = rowcount + 1;
    }

    return return_colums;
}

And the listview act:

public ListView whiskeylist;
public String[] DataArryWhiskey;  

      @Override
protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main);

    // Start db view of whiskey

    DBConfig whiskeyrows = new DBConfig(this);


    whiskeyrows.open();
    DataArryWhiskey = whiskeyrows.getDataInArray();
    whiskeyrows.close();

    Toast.makeText(MainScreen.this, result, Toast.LENGTH_LONG).show();

    whiskeylist = (ListView)findViewById(R.id.listofWhiskey);
    whiskeylist.setAdapter(new ArrayAdapter<String>(this,android.R.layout.simple_list_item_1 , DataArryWhiskey));


    // End db view of whiskey

}// end onCreate

I keeps on crashing, can anybody help met a bit? Thx in advance

If you need to pass the data to the listView, why didn't you use the SimpleCursorAdapter instead? — Mohamed_AbdAllah
– Mohamed_AbdAllah, Commented Dec 24, 2011 at 20:48

AAnkit · Accepted Answer · 2011-12-24 20:50:10Z

1

Moved return_colums defination and declaration.

public String[] getDataInArray() { // get data for list and return in array form
// TODO Auto-generated method stub

String[] columms = new String[]{ KEY_ROWID, KEY_NAME};


Cursor c = currentdatabase.query(DATABASE_TABLE, columms, null, null, null, null, null);

int iRow = c.getColumnIndex(KEY_ROWID);
int iName = c.getColumnIndex(KEY_NAME);
int rowcount = 0;
  String[] return_colums = new String[c.getCount()];
for(c.moveToFirst(); !c.isAfterLast(); c.moveToNext())
{
    return_colums[rowcount] = c.getString(iName) + "," + c.getString(iRow);
    rowcount = rowcount + 1;
}

return return_colums;
}

answered Dec 24, 2011 at 20:50

AAnkit

27.6k12 gold badges62 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:22:20Z

0

Move whiskeyrows.close(); from onCreate() to onDestroy(). More details in this link

edited May 23, 2017 at 12:22

CommunityBot

11 silver badge

answered Dec 24, 2011 at 20:40

Mohamed_AbdAllah

5,3203 gold badges31 silver badges47 bronze badges

5 Comments

Mohamed_AbdAllah Over a year ago

You need to put the whiskeyrows as global variale: <br/>

public String[] DataArryWhiskey; <br/> DBConfig whiskeyrows;  <br/>       @Override  <br/> protected void onCreate(Bundle savedInstanceState) {  <br/>     // TODO Auto-generated method stub  <br/>     super.onCreate(savedInstanceState);  <br/>     setContentView(R.layout.main);  <br/> <br/>     // Start db view of whiskey  <br/>      whiskeyrows = new DBConfig(this);

<br/> If you need to pass the data to the listView, why didn't you use the SimpleCursorAdapter instead?

user1114720 Over a year ago

i am realy a noob on adroid programming, i would like to use a simple cursor but i don't know how to transfrom this into my situation. i alsow cant get the code to work with your extra comment.

user1114720 Over a year ago

Strange thing is that it dit work and i still get a returnmessage if i use a string instead of a array.

Mohamed_AbdAllah Over a year ago

It is simple to use SimpleCursorAdapter. Just load your cursor, rows to display and the layout representing each row in the listView in the adapter (SimpleCursorAdapter(Context context, int layout, Cursor c, String[] from, int[] to)) and set the adapter of your listView to this SimpleCursorAdapter. This is much simpler than your implementation.

user1114720 Over a year ago

Thx for the help i am going to read the tutorial vogella.de/articles/AndroidSQLite/article.html

Collectives™ on Stack Overflow

Android: Put SQL data into array

2 Answers 2

Comments

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related