XML parsing with attributes that is empty (Android)

Question

i have an xml file with attributes like this:

  <folder name = 'somename' description = ''/>

i want to display the description attribute as 'null' but it force closes and throws a FATAL Exception main in the LogCat.

i have this code below at the startElement() method

   if (localName.equalsIgnoreCase("folder")) {
      /** Get attribute value */
      if(attributes.getValue("description")== "null"){
         parseList.setFolderdesc(null);
      }else{
         String desc = attributes.getValue("description");                   
         parseList.setFolderdesc(desc);
      }

i tried this code but no luck... how will i solve this without changing my xml file?

your problem is not detailed enough. what are you trying to do and why when does it force close? — Joe
– Joe, Commented Dec 12, 2011 at 7:03
that because it cant be set to null object.. just use something different then .. for example set a Boolean to false and then on the display part - if its false then don't display .. or some other clever maneuver. this force close is totally legit and doesn't relate to your XML .. — Joe
– Joe, Commented Dec 12, 2011 at 7:16
It would help if you told us what exception is being thrown ... as reported by LogCat. — Stephen C
– Stephen C, Commented Dec 12, 2011 at 7:18

Sunil Kumar Sahoo · Accepted Answer · 2011-12-12 07:11:53Z

1

try with the following code

String desc = null;
        try{
        desc = attributes.getValue("description");
        if((desc == null) || (desc.length()<=0)){
            desc = null;    
        }
        }catch(Exception ex){
            desc = null;
        }
if(parseList != null){
parseList.setFolderdesc(desc);  
}

answered Dec 12, 2011 at 7:11

Sunil Kumar Sahoo

53.7k55 gold badges182 silver badges244 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Stephen C Over a year ago

Uggh. Your belt-and-braces exception handling is going to obscure any bugs. Catching Exception is evil ... just don't do it!!

Stephen C Over a year ago

@nhqdualcagony - it might "work", but it is extremely bad practice to catch Exception. For instance, if attributes itself was null due to some bug in your code, then Sunil's code would make it difficult for you to find that bug.

Sunil Kumar Sahoo Over a year ago

@Stephen, thanks for your effort. I know it is not the good to catch Exception But it is not bad always. in some case eg if you want to so generic error message to the user irrespective of any type of Exception i that case you have to handle catch.

Sunil Kumar Sahoo Over a year ago

@All, Also I feel Handle Catch in outermost layer (calling environment) if possible.

Stephen C Over a year ago

@SunilKumarSahoo - I'll grant you that case. But your example is not that case.

Stephen C · Accepted Answer · 2011-12-12 07:22:00Z

1

This code doesn't do what you expect:

  if (attributes.getValue("description") == "null") {

You are comparing the attribute value with the String "null" not with a java null. (And you are testing strings the unsafe way too! Strings should be tested for equality using String.equals() not the == operator.)

That test should be written as follows:

  if (attributes.getValue("description") == null) {

or better still:

  if (attributes.getValue("description") == null || 
      attributes.getValue("description").isEmpty()) {

(I'm not sure whether this will fix you problem, because I don't understand your problem description.)

edited Dec 12, 2011 at 7:22

answered Dec 12, 2011 at 7:13

Stephen C

723k95 gold badges849 silver badges1.3k bronze badges

Collectives™ on Stack Overflow

XML parsing with attributes that is empty (Android)

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related