python variable passing problems

Question

A little while ago I decided to take on a text adventure game. I always wanted to do that. But the first time it did an epic fail. This time I'm getting closer but just not there. I think I saw the error, though: The problem is that the variable isn't carried to the next def. So the thing I want to know is how do I solve it?

This is the piece of code that describes the problem:

def start():
    print "Hello there Knight... Knight? Sir Knight, what's your name?"
    name = raw_input("> ")
    print "Well sir %s of simpleton. We have a message from the queen, do you want to read it?" % name
    rm = raw_input("> ")
    rm(rm)

def rm(rm):
    if rm ==  "yes":
        print "It says: \n Dear %s, \n Our kingdom is in great danger. Dragon Redpole has captured the beatiful princess. Who ever saves her    rom his dangerous castle may marry her." % name
        print "What will you do? Go undercover to The Far Lands or in full weaponry"
        UorW = raw_input("type u or fw \n > ")
    elif rm ==  "no":
        print "I am sorry sir, but the queen's word is la.. SHUT UP YOU USELESS PIECE OF TRASH OUT OF THIS ROOM NOW!! You say highly irritated. Will you tell the torturer to torture  the butler in the dungeons?"
        torture_butler = raw_input(">  ")    
        torture_butler()
    else: 
        print "That's not possible"

This is the report I get:

Traceback (most recent call last):
  File "story.py", line 59, in <module>
    start()
  File "story.py", line 6, in start
    rm(rm)
TypeError: 'str' object is not callable

Please fix the indentation, this code won't run as it is posted. — NullUserException
– NullUserException, Commented Nov 20, 2011 at 23:27

Sven Marnach · Accepted Answer · 2011-11-20 23:30:05Z

6

You overwrite the function named rm() with the return value of raw_input("> "). After this line, the name rm will point to a string object, and trying to call this string object fails because string objects aren't callable. Rename the variable so that it does not shadow the function name.

answered Nov 20, 2011 at 23:30

Sven Marnach

608k123 gold badges966 silver badges865 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

srgerg · Accepted Answer · 2011-11-20 23:39:21Z

1

From the way your code is written, the name rm does not refer to the function of that name in either the start function, nor the rm function. In both cases rm is a local variable which hides the function definition.

As has already been suggested in other answers, you need to avoid overloading the same name with multiple meanings.

answered Nov 20, 2011 at 23:39

srgerg

19.4k4 gold badges59 silver badges40 bronze badges

Collectives™ on Stack Overflow

python variable passing problems

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related