MySQL syntax error with simple INSERT?

Question

With this php/mysql query:

mysql_query("INSERT INTO Follows (User, Following, Type) VALUES ('$_COOKIE[user]', '$genre', 'Genre'")

I am getting the syntax error

"You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1"

I see nothing wrong with this syntax. Does anyone else?

It depends what the values of those variables are... you should really be escaping them — Ken Keenan
– Ken Keenan, Commented Oct 21, 2011 at 21:31
Among other concerns, you're missing the ending ) for VALUES — No Results Found
– No Results Found, Commented Oct 21, 2011 at 21:31
Seriously?! It's 2011 and we're still using string interpolation for SQL queries? — Phil
– Phil, Commented Oct 21, 2011 at 21:31
Yep, chances are the variables are causing your headache, one of them contains an apostrophe or slash or is empty altogether. — Mike Purcell
– Mike Purcell, Commented Oct 21, 2011 at 21:33

Community · Accepted Answer · 2017-05-23 11:47:58Z

6

You have a missing parenthesis:

mysql_query("INSERT INTO ... VALUES (... , 'Genre'")

Should be:

mysql_query("INSERT INTO ... VALUES (... , 'Genre')")
                                                  ^

You also have an SQL injection vulnerability in your code. Use mysql_real_escape_string or parameterized queries. Related:

Best way to stop SQL Injection in PHP

edited May 23, 2017 at 11:47

CommunityBot

11 silver badge

answered Oct 21, 2011 at 21:31

Mark Byers

843k202 gold badges1.6k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mob · Accepted Answer · 2011-10-21 21:33:13Z

0

You did not close your last bracket in the query.

mysql_query("INSERT INTO Follows (User, Following, Type) VALUES ('$_COOKIE[user]', '$genre', 'Genre')")

answered Oct 21, 2011 at 21:33

Mob

11.1k7 gold badges43 silver badges58 bronze badges

Comments

Jules · Accepted Answer · 2011-10-21 21:33:02Z

-1

The error is that you're not closing your MySQL statement with the corresponding bracket.

Yours:

mysql_query("INSERT INTO Follows (User, Following, Type) VALUES ('$_COOKIE[user]', '$genre', 'Genre'");

Correct:

mysql_query("INSERT INTO Follows (User, Following, Type) VALUES ('$_COOKIE[user]', '$genre', 'Genre')");

answered Oct 21, 2011 at 21:33

Jules

7,2236 gold badges28 silver badges51 bronze badges

Collectives™ on Stack Overflow

MySQL syntax error with simple INSERT?

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related