PHP MySQL data FOR loop

Question

<?php

//function to create a table
function makeTable($table, $columns){
    $numFields = count($columns)-1;

    $query = 'SELECT * FROM '.$table;
    $result = mysql_query($query);
    $arrayResult = mysql_fetch_array($result);
    $num_rows = mysql_num_rows($result);

    for ($x = 1; $x <= $num_rows; $x++){ //1st for loop
        echo '<tr>';
            for ($i = 0; $i <= $numFields; $i++){ //2nd for loop
                echo '<td>'.$arrayResult[$columns[$i]].'</td>';
            }
        echo '</tr>';
    }
}

?>

$columns is an array entered by the user eg: $columns = array ('Column1', 'Column2', 'Column3);. These are the names of the columns which are in a given $table.

My idea was to create a function that displays the data from the MySQL table with the info from the $columns array. The problem is in the second for loop. The value of $i is reset every time the first loop is done, so I get the same result over and over again (the number of rows in the table). My question is this: How do I keep the $i in the second loop from resetting?

Thank you in advance.

Define $i=0; before the first loop then (and leave the first for ( ; $i<= expression empty). You'll probably find out that this isn't what you actually want then. Investigate using foreach and while instead. — mario
– mario, Commented Oct 19, 2011 at 7:26

xdazz · Accepted Answer · 2011-10-19 07:29:37Z

3

The reason you get the same result over and over is not because $i, but $arrayResult.

The right way is like this:

//function to create a table
function makeTable($table, $columns){
    $numFields = count($columns)-1;
    $query = 'SELECT * FROM '.$table;
    $result = mysql_query($query);

    while ($arrayResult = mysql_fetch_array($result)){
        echo '<tr>';
            for ($i = 0; $i <= $numFields; $i++){ //2nd for loop
                echo '<td>'.$arrayResult[$columns[$i]].'</td>';
            }
        echo '</tr>';
    }
}

answered Oct 19, 2011 at 7:29

xdazz

161k38 gold badges255 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Damien Pirsy · Accepted Answer · 2011-10-19 07:38:08Z

1

In your code you simple fetch always the first row and regardless of the subsequent cycles you only deal with that first row.

Just place

 $arrayResult = mysql_fetch_array($result);

within the first loop just before echo '<tr>';

Anyway, for is not the best choice for iterating the records of a table, consider using while.

edited Oct 19, 2011 at 7:38

Damien Pirsy

25.5k8 gold badges72 silver badges77 bronze badges

answered Oct 19, 2011 at 7:30

Nedret Recep

7285 silver badges8 bronze badges

Comments

Rajan Rawal · Accepted Answer · 2011-10-19 07:38:23Z

-1

Why Dont you use while loop? If you use while you even don't need mysql_num_rows($result). Try this

function makeTable($table, $columns){
    $numFields = count($columns)-1;

    $query = 'SELECT * FROM '.$table;
    $result = mysql_query($query);

    while($arrayResult = mysql_fetch_array($result)){
        echo '<tr>';
            for ($i = 0; $i <= $numFields; $i++){ //2nd for loop
                echo '<td>'.$arrayResult[$columns[$i]].'</td>';
            }
        echo '</tr>';
    }
}

I m sure, you will get your ans

answered Oct 19, 2011 at 7:38

Rajan Rawal

6,3236 gold badges44 silver badges62 bronze badges

Comments

Your Common Sense · Accepted Answer · 2011-10-19 07:39:06Z

-2

Your code won't work ever. Because you didn't read manual entry for mysql_fetch_array()
There is no use for the for loops these days. You need some manual to see how to deal with loops in PHP. foreach and while you will need more often than for.
The idea of creating such a function is wrong. combining SQL and HTML in one function is a sign of VERY BAD design. What you really need is a function to get SQL data into array and a template.

a function

function sqlArr($sql){
  $ret = array();
  $res = mysql_query($sql) or trigger_error(mysql_error()." ".$sql);
  if ($res) {
    while($row = mysql_fetch_array($res)){
      $ret[] = $row;
    }
  }
  return $ret;
}

a code

$data = sqlArr("SELECT * FROM table");
include 'template.php';

a template

<table border='1'>
<? foreach ($data as $row): ?>
  <tr>
  <? foreach ($row as $col): ?>
    <td><?=$col?></td>
  <? endforeach ?>
  </tr>
<? endforeach ?>
</table>

However, you can put this latter template code into function, if you're gonna use it often.
and call it like

<? drawTable($data) ?>

edited Oct 19, 2011 at 7:39

answered Oct 19, 2011 at 7:33

Your Common Sense

158k42 gold badges226 silver badges373 bronze badges

7 Comments

abruski Over a year ago

:D This my second day of PHP learning. The code works when the mysql_fetch_array is put in another position. Why is it bad combining SQL data and HTML?

Your Common Sense Over a year ago

LOl you are sure in the position to judge :) indeed PHP is your language. go on.

abruski Over a year ago

I'm judging by the "helpful" explanations you provide and the way you treat other people. Don't answer any of my future questions.

Your Common Sense Over a year ago

you have no experience to judge, silly :) And I'll answer whatever questions I find necessary to.

Your Common Sense Over a year ago

but you can't judge if someone is ignorant or not in the area you are learning for the very first day - can you? :)

|

Collectives™ on Stack Overflow

PHP MySQL data FOR loop

4 Answers 4

Comments

Comments

Comments

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related