PHP, MySQL table query syntax error?

Question

I hope someone can help see what's wrong here: I have a form with two field EMAIL and PASSWORD that opens a php page where I intend to run a simple query on a table. I get an error message that makes no sense:
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '@gmail.com' at line 1.
The email address I entered in this case did end with '@gmail.com'
Here's the code:

<?php
$dbhost = 'somewhere.net';
$dbuser = 'someUser';
$dbpass = 'pass';

$conn = mysql_connect($dbhost, $dbuser, $dbpass) or die ('Error connecting to mysql');

$dbname = 'medreunten_db1';
mysql_select_db($dbname) or die(mysql_error($conn)); 

$email = mysql_real_escape_string($_POST['email']);

$query = "SELECT * FROM employee WHERE email = $email";
$result = mysql_query($query, $conn) or die (mysql_error($conn));
extract(mysql_fetch_assoc($result));  


while ($row = mysql_fetch_array($result)) {
extract($row);
echo $row['name'];
echo $row['surname'];
echo $row['age'];
}
?>

Any advice would be appreciated.

$query = "SELECT * FROM employee WHERE email = '$email'"; OR $query = "SELECT * FROM employee WHERE email = ".$email; — Ehtesham
– Ehtesham, Commented Sep 26, 2011 at 11:36
yes. I ran into more problems because I inserted the mysql_real_escape_string before the db connection and I wanted to carry on in that thread, but I think I commented and that was unacceptable, so the mods deleted it and downvoated me. so i started a new question. — Max
– Max, Commented Sep 26, 2011 at 11:59

Maxim Krizhanovsky · Accepted Answer · 2011-09-26 11:35:47Z

6

You are missing quotes around string fields:

$query = "SELECT * FROM employee WHERE email = '$email'";

Additionally,

extract(mysql_fetch_assoc($result));

will fetch the first row from the database, so your while loop will start from the second row.

answered Sep 26, 2011 at 11:35

Maxim Krizhanovsky

26.8k5 gold badges62 silver badges91 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Max Over a year ago

thanks for pointing that out, I fixed both errors and it works :)

johannes · Accepted Answer · 2011-09-26 11:36:16Z

0

You have to put the value in quotes inside SQL string.

$email = mysql_real_escape_string($_POST['email']);

$query = "SELECT * FROM employee WHERE email = '$email'";

(mind the extra '' around $email)

answered Sep 26, 2011 at 11:36

johannes

16k3 gold badges47 silver badges57 bronze badges

Comments

klaustopher · Accepted Answer · 2011-09-26 11:37:26Z

0

Your query translates to:

SELECT * FROM emloyee WHERE email = [email protected]

This doesn't work, you have to put strings in quotes. Change your code to the following and it will work:

$query = "SELECT * FROM employee WHERE email = '$email'";

answered Sep 26, 2011 at 11:37

klaustopher

6,9591 gold badge24 silver badges26 bronze badges

Comments

Bajrang · Accepted Answer · 2011-09-26 11:38:13Z

0

Just single quote the variable '$email' because it varchar type value and field . As wrote, Darhazer :)

answered Sep 26, 2011 at 11:38

Bajrang

8,6795 gold badges29 silver badges40 bronze badges

Comments

Olli · Accepted Answer · 2011-09-26 11:41:00Z

0

Full fixed code:

<?php
$dbhost = 'somewhere.net';
$dbuser = 'someUser';
$dbpass = 'pass';

$conn = mysql_connect($dbhost, $dbuser, $dbpass) or die ('Error connecting to mysql');

$dbname = 'medreunten_db1';
mysql_select_db($dbname) or die(mysql_error($conn)); 

$email = mysql_real_escape_string($_POST['email']);

$query = "SELECT * FROM employee WHERE email = '$email'";
$result = mysql_query($query, $conn) or die (mysql_error($conn));
extract(mysql_fetch_assoc($result));  


while ($row = mysql_fetch_array($result)) {
extract($row);
echo $row['name'];
echo $row['surname'];
echo $row['age'];
}
?>

answered Sep 26, 2011 at 11:41

Olli

7526 silver badges20 bronze badges

Collectives™ on Stack Overflow

PHP, MySQL table query syntax error?

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related