mongoose update on array of objects

Question

im trying to make an update on my bd, but the problem is that i dont have an id per object, the only thing i can identify by its the "description" property. I want to update that property value but first i have to find it and update it as well, this is the json

{
  "_id": {
    "$oid": "637c1064a2f047f5ab75ac42"
  },
  "title": "this is a list",
  "todo": [
    {
      "completed": false,
      "description": "a normal task"
    },
    {
      "completed": false,
      "description": "this is another task"
    },
    {
      "completed": false,
      "description": "another task"
    }
  ],
  "username": "lucas",
  "__v": 3
}

This is what im trying to do, im trying to update the property description with a new description, but first i have to find the same element that matches with whats in the body.

  List.findOneAndUpdate(
        {todo: {description: req.body.description}},// trying to find it here
        {$set:{todo : {description: req.body.newDescription}}}, //trying to change it here
        function(err, response) {
            console.log(err,response)
          }
    )

J.F. · Accepted Answer · 2022-11-23 15:46:38Z

1

You have a couple mistakes:

First one is you are using {todo: {description: req.body.description}} to find the object. In this way, mongo tries to compare using the whole object, that means only will return a match if todo is equal to description: value. But todo is an array and it contains objects.

Take a look to the dot notation docs

The second part is to use positional operator $. With $ you can tell mongo "get the element you have found in the prevous stage and update with the new value".

So you can try this query:

List.findOneAndUpdate({
  "todo.description": req.body.description
},
{
  "$set": {
    "todo.$.description": req.body.newDescription
  }
})

Example here

answered Nov 23, 2022 at 15:46

J.F.

15.3k10 gold badges41 silver badges74 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Lucas Over a year ago

Thanks for that but doesnt work, idk why, im sending this: { "title": "this is a list", "completed": false, "description": "this is another task", "newDescription" : "updated task", "username": "lucas" }

Lucas Over a year ago

i try with findOneAndUpdate and updateOne

Lucas Over a year ago

now works but with a function as third parameter, but why?

J.F. Over a year ago

I think you have to try something like this

J.F. Over a year ago

Do you use await? Otherwise you can get the data in the callback (the function)

|

Collectives™ on Stack Overflow

mongoose update on array of objects

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related