C# Load items from file and split into array

Question

HI guys i'm trying to load the contents of my file "item.ids" which currently holds this:

1:Stone
2:Grass
3:Dirt

I want to read each line the the file and split it at the ":". I am using the following code:

    foreach(String line in File.ReadAllLines("item.ids")) {
        items = line.Split(':');
    }

    foreach (String part in items)
    {
        addToList(specs, part);
    }



}


public void addToArray(Array array, int index, String s)
{
    try
    {

        array.SetValue(s, index);
    }
    catch (Exception ex)
    {
        addToList(specs, ex.ToString());
    }
}

public void addToList(ListBox listbox, String s)
{
    listbox.Items.Add(s);
}

This works but it only does the last line so it will output it like so:

3
dirt

If you could help me along with my code it would be very helpful.

Where are you calling addtoarray? Agar exactly are you wanting to do with your values? — tam
– tam, Commented Sep 16, 2011 at 2:19

Austin Salonen · Accepted Answer · 2011-09-16 02:16:54Z

4

You need to fill the list after every read.

foreach(String line in File.ReadAllLines("item.ids")) 
{
    items = line.Split(':');

    foreach (String part in items)
    {
        addToList(specs, part);
    }
}

... otherwise you're only ever adding the last item by default.

answered Sep 16, 2011 at 2:16

Austin Salonen

50.4k16 gold badges112 silver badges140 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Duncan Palmer Over a year ago

Oh yes haha, That's why. Thanks :)

rtalbot · Accepted Answer · 2011-09-16 02:18:09Z

1

In the 1st loop you set the item field each time you iterate so when you exit the loop it will be set to the last value. You probably want to change to something like this:

foreach(String line in File.ReadAllLines("item.ids")) 
{         
     foreach (String part in line.Split(':'))
     {         
          addToList(specs, part);     
     } 
}

answered Sep 16, 2011 at 2:18

rtalbot

1,64510 silver badges13 bronze badges

Comments

gaynorvader · Accepted Answer · 2012-12-05 10:41:54Z

0

You've closed your loop to early so items will only contain the last iteration

change your code to:

    foreach(String line in File.ReadAllLines("item.ids")) 
    { 
        items = line.Split(':'); 

        foreach (String part in items) 
        { 
            addToList(specs, part); 
        } 
    }

edited Dec 5, 2012 at 10:41

gaynorvader

2,6573 gold badges21 silver badges36 bronze badges

answered Sep 16, 2011 at 2:19

Bob Vale

18.5k1 gold badge44 silver badges51 bronze badges

Collectives™ on Stack Overflow

C# Load items from file and split into array

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related