0

So I need to add different string variables to array and then split each of them by whitespace into array splitted[]

var books = new Array()
var a = "Lorem Ipsum dolor sit amet"
var b = "never gonna give you up"
var c = "another string variable"
books.push(a); books.push(b); books.push(c)

var splitted = []
for (let i = 0; i < books.length; i++) {
  splitted = books[i].split(/[\s]+/)
}
console.log(splitted)

Expected result: (13)['Lorem', 'Ipsum', ... 'string', 'variable']
Actual result: (3)['another', 'string', 'variable']
So only the last variable c is splitted, while all three vars are in books[].

Improve this question
5
  • plitted = books[i].split(/[\s]+/) is the problem,you need to store all the result into a global array Commented Oct 21, 2022 at 11:37
  • @lucumt "you need to store all the result into a global array" - splitted is exactly that Commented Oct 21, 2022 at 11:40
  • You're usind .push() to add a, b and c to books but then = in the loop. Why? Commented Oct 21, 2022 at 11:41
  • Off-topic: .push() can handle multiple elements -> books.push(a, b, c) Commented Oct 21, 2022 at 11:42
  • What you mean? What's the difference, isn't splitted[] global? I can also write splitted.push(books[i].split(/[\s]+/)) and output is three arrays inside the splitted[] Commented Oct 21, 2022 at 11:51

3 Answers 3

Reset to default
3

Need to change

splitted = books[i].split(/[\s]+/)

to

splitted.push(books[i].split(/[\s]+/))

so that the latter result will not override the previous one

var books = new Array()
var a = "Lorem Ipsum dolor sit amet"
var b = "never gonna give you up"
var c = "another string variable"
books.push(a); books.push(b); books.push(c)

var splitted = []
for (let i = 0; i < books.length; i++) {
  splitted.push(...books[i].split(/[\s]+/))
}
console.log(splitted)

Improve this answer
Sign up to request clarification or add additional context in comments.

3 Comments

Would be a bit cleaner with map() and concat(), or better flatMap.
@SebastianSimon flat() might also work,and thanks for point out,I have learned a new skill for ...Object
Or using spread operator like so splitted = [...splitted, ...books[i].split(/[\s]+/)]
0

How about just using join and split? join joins the three array items (a, b, c) together into one string (separated by a space " ") and split splits them up and returns all split items in a new array:

var books = new Array()
var a = "Lorem Ipsum dolor sit amet"
var b = "never gonna give you up"
var c = "another string variable"
books.push(a); books.push(b); books.push(c);

var splitted = books.join(" ").split(/[\s]+/)

console.log(splitted)

or concatenate the strings first (without pushing them to an array, although you said you wanted them in an array)

var a = "Lorem Ipsum dolor sit amet"
var b = "never gonna give you up"
var c = "another string variable"
var abc = a + " " + b + " " + c

var splitted = abc.split(/[\s]+/)

console.log(splitted)

Improve this answer

Comments

0

So I solved this but not in a best way. I simply wrote .push(books[i].split()), to get three arrays in splitted[], then made three arrays one writing splitted.flat(1)

var books = new Array()
var a = "Lorem Ipsum dolor sit amet"
var b = "never gonna give you up"
var c = "another string variable"
books.push(a, b, c)

var splitted = []
for (let i = 0; i < books.length; i++) {
  splitted.push(books[i].split(/[\s]+/))
}
splitted = splitted.flat(1)
console.log(splitted)
Improve this answer

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.