Mysql query not working?

Question

I am making a simple friends feature for my site and when people get a friend request I want it to show on there friends panel link so I tried this.

 $q = $dbc -> prepare("SELECT id_to read FROM friend_requests WHERE id = ? && read == '0'");
 $q -> execute(array($details['id']));
 $request_count = $q -> rowCount();
 if ($request_count > 0) {
echo '<li><a href="/friends"><img src="/gameimages/friends.png" height="16" width="16" alt="" /><strong>Friends (' . $request_count . ')</strong></a></li>';
 }
 else {
echo $request_count;
echo '<li><a href="/friends"><img src="/gameimages/friends.png" height="16" width="16" alt="" />Friends </a></li>';
 }

Now on the friends page where requests are shown all requests get the column of read set to 1, and by default it is 0. If there are rows with 0 it shall be a new request and the query above should fire letting users know that they have new requests, what am I doing wrong?

regality · Accepted Answer · 2011-09-13 22:17:38Z

3

The problem is your query:

SELECT id_to read FROM friend_requests WHERE id = ? && read == '0'

should be

SELECT id_to, read FROM friend_requests WHERE id = ? and read = '0'

answered Sep 13, 2011 at 22:17

regality

6,5846 gold badges31 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

JK. · Accepted Answer · 2011-09-13 22:23:47Z

1

Read is a reserved word in MySQL and need to be escaped with backticks:

SELECT id_to, `read` FROM friend_requests WHERE id = ? AND `read` = '0';

answered Sep 13, 2011 at 22:23

JK.

5,1261 gold badge29 silver badges26 bronze badges

2 Comments

carlgcode Over a year ago

Ah ok even when I did the above it still did not work, and I have always used && in my mysql statements, what is this reserved for, do you know, and thanks :)

JK. Over a year ago

Some words need to be reserved for the SQL to be properly interpreted. SELECT select ... is rather ambiguous don't you think? Read documentation for further information: dev.mysql.com/doc/refman/5.5/en/reserved-words.html

dispake · Accepted Answer · 2011-09-13 22:17:52Z

1

&& read == '0'

Did you mean

 AND read = 0

?

answered Sep 13, 2011 at 22:17

dispake

3,3372 gold badges21 silver badges22 bronze badges

Collectives™ on Stack Overflow

Mysql query not working?

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related