Subscript out of range error (with array)

Question

I have this code in VBS:

Dim Arg()
Set objArgs = WScript.Arguments
for i=0 to objArgs.Count
  Arg(i) = Replace(objArgs(i),"\n",vbNewLine,1,-1,1)
... (yes, the for has a Next at the end)

(example arguments: "hello\nworld" "test" 0 64)

But when I run it, it throws an error: The subscript is out of range (line 4, column 3).

Am I incorrectly using the arrays, or is the problem in the for, or what is wrong?

Indexing starts at 0 but Count is 1 larger than the last index. objArgs.Count - 1 — Rno
– Rno, Commented Jul 22, 2022 at 22:07
If you have 0 to 9 for example the count of the array elements would be 10. So at the moment you are looping 0 to 10 where the 11th element doesn’t exist hence the subscript out of range error. — user692942
– user692942, Commented Jul 23, 2022 at 9:51

user692942 · Accepted Answer · 2022-07-26 12:53:43Z

3

Arrays in VBScript are zero ordinal based that means that if you have for example ten elements in the array they will be numbered zero to nine.

So when using Count it will return the number of elements not their position in the array so you will need to minus one from the Count or VBScript will report a "Subscript out of range" error as there is no 11th element in the array to iterate to.

As suggested in the comments, you want to do this;

For i = 0 To objArgs.Count - 1

The other issue is you declare a dynamic array (Dim Args()) but never initialise it before trying to insert elements into it. You could see this answer to a similar question that explains the problem. When using a dynamic array declaration you need to initialise it using ReDim.

Useful Links

edited Jul 26, 2022 at 12:53

answered Jul 23, 2022 at 10:03

user692942

16.4k8 gold badges85 silver badges196 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

aritz331_ Over a year ago

same error, even tho i changed it

user692942 Over a year ago

I think the other problem is the use of Dim Args(). See subscript out of range while adding items to array

aritz331_ Over a year ago

that was the problem: dimming things without a fixed length

user692942 Over a year ago

You don’t need to have a fixed length, ReDim Preserve allows to dynamically increase the array as you go while still maintaining the existing data.

aritz331_ Over a year ago

then i can dim Arg() with ReDmin Preserve?

|

Collectives™ on Stack Overflow

Subscript out of range error (with array)

1 Answer 1

Useful Links

8 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Useful Links

8 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related