Count each character in a string

Question

I have to count character in a string and i'm a little stuck. If input data is "test", the result will be t=2; e=1; s=1; and so on.In my code, the result is t=1; e=1; s=1; and i don't know how to make to work correctly.

Input data

test

Output data   
t=2
e=1
s=1

Here is my code

public static void Main()
{
    string text = Console.ReadLine();
    string distinctChars = GetDistinctChars(text);
    foreach (char c in distinctChars)
    {
        Console.WriteLine(c + " " + CountCharOccurrences(distinctChars, c));
    }
    Console.ReadLine();

}
private static int CountCharOccurrences(string text, char charToCount)
{
    int count = 0;

    foreach (char c in text)
    {
        if (c == charToCount)
        {
            count++;
        }
    }
    return count;
}

private static string GetDistinctChars(string text)
{
    string result = "";
    foreach (char c in text)
    {
        if (result.IndexOf(c) == -1)
        {
            result += c;
        }
    }
    return result;
}

increment the dictionary in this method?"CountCharOccurrences" — BogdanNetan
– BogdanNetan, Commented Jul 7, 2022 at 16:54
You are calculating the counts on the distinct chars - of course you get 1 — Hans Keﬆing
– Hans Keﬆing, Commented Jul 7, 2022 at 16:54

Hogan · Accepted Answer · 2022-07-07 16:56:45Z

3

This line

       Console.WriteLine(c + " " + CountCharOccurrences(distinctChars, c));

should be

       Console.WriteLine(c + " " + CountCharOccurrences(text , c));

There are better ways to do this than how you are doing it. Using a Dictionary object is probably the best. Then you only need to loop over the original text once.

edited Jul 7, 2022 at 16:56

answered Jul 7, 2022 at 16:55

Hogan

70.7k10 gold badges83 silver badges119 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mong Zhu Over a year ago

"better ways to do this" they probably haven't learnt about dictionaries yet. IMHO this is a nice algorithmic solution to this problem

Hogan Over a year ago

@MongZhu -- exactly why I put it the way I did -- something to look forward to learning about on the journey

Collectives™ on Stack Overflow

Count each character in a string

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related