changing css class from code behind variable - way to avoid?

Question

I need to change the background of a div based on some count property set in the code behind. I can get it to work as below. But i'm wondering if this is a good practice. If I need to change the count logic, I have to update code vs html. I suppose Jquery can't do this unless I have a hidden variable with count on the page. Is this better than writing an If loop logic within the html?

html

<div class="show <%=CSSClass %>">  value </div>

code behind

public string CSSClass
            {
                get
                {
                    if (count > 1) return "bright";

                    else if (count == 0)
                        return "normal";

                    return "dim";
                }
            }

Aside: that's a strangely structured if else if. Did you really intend for "dim" to be mapped to count == 1 || count < 0? — jball
– jball, Commented Sep 1, 2011 at 20:15
if count > 1, return bright; if count = 0, return normal; else (if count < 1), return dim. I didn't have the == before, I updated it. — Alex J
– Alex J, Commented Sep 1, 2011 at 20:24
Yeah, i agree. this is just meant for illustrative purpose. First condition should really be if(count >=1) in this case. — Alex J
– Alex J, Commented Sep 1, 2011 at 20:34

Darin Dimitrov · Accepted Answer · 2011-09-01 20:08:02Z

1

That's a good practice. I would stick with it. If you wanted to do it with jQuery you could expose the count server side property to the client and perform the same logic on the client. Note however that because this is done on the client there might be some delay after the page has rendered and the jQuery code has assigned the proper classname, so you could observe a flickering when the actual CSS class is applied to the DOM element on the client side.

answered Sep 1, 2011 at 20:08

Darin Dimitrov

1.0m275 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Alex J Over a year ago

but this way, if have to change the count condition or css class names, i need to do a release. is that avoidable?

Darin Dimitrov Over a year ago

@Alex J, what do you mean that you have to do a release? I don't understand your question. You will simply output the count variable in your javascript: var count = <%= count %>;. So if you change the count value on your server the javascript count variable will obviously be updated as well.

Alex J Over a year ago

Sorry, thats not what I meant. I meant if the logic/condition of calculating the css class changes, i will need to update code vs updating aspx html.

jball Over a year ago

If you must have it be embedded in the aspx for changing on the fly, you can use the ? conditional operator to significantly shorten it: <div class="show <%= count > 1 ? "bright" : count == 0 ? "normal" : "dim" %>">

Diodeus - James MacFarlane · Accepted Answer · 2011-09-01 20:07:42Z

0

Class names are a perfectly valid way to do this, so is your technique of doing it on the server.

answered Sep 1, 2011 at 20:07

Diodeus - James MacFarlane

115k33 gold badges164 silver badges180 bronze badges

Comments

Nachshon Schwartz · Accepted Answer · 2011-09-01 20:10:11Z

0

If your trying to use the MVC methodology there is no need for this.

the point in MVC is to make sure that you have no buisness logic in your view, and since this not logic of that type it seems to complicated, I would put the if in the page.

Unless of course you are gonna use this alot and then this would be perhaps not a bad idea.

answered Sep 1, 2011 at 20:10

Nachshon Schwartz

15.9k20 gold badges65 silver badges99 bronze badges

Collectives™ on Stack Overflow

changing css class from code behind variable - way to avoid?

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related