How to use Moq framework correctly - basic question

Question

I've never used any Mock frameworks and actually new to ASP.NET MVC, testing and all this related stuff.

I'm trying to figure out how to use Moq framework for testing, but can't make it work. that's what I have at the moment: My repository interface:

public interface IUserRepository {
    string GetUserEmail();
    bool UserIsLoggedIn();
    ViewModels.User CurrentUser();
    void SaveUserToDb(ViewModels.RegisterUser viewUser);
    bool LogOff();
    bool LogOn(LogOnModel model);
    bool ChangePassword(ChangePasswordModel model);
}

My Controller constuctor, I'm using Ninject for injection, it works fine

private readonly IUserRepository _userRepository;

public HomeController(IUserRepository userRepository) {
    _userRepository = userRepository;
}

Simplest method in controller:

public ActionResult Index() {
    ViewBag.UserEmail = _userRepository.GetUserEmail();
    return View();
}

And my test method:

    [TestMethod]
    public void Index_Action_Test() {

        // Arrange
        string email = "[email protected]";
        var rep = new Mock<IUserRepository>();
        rep.Setup(r => r.GetUserEmail()).Returns(email);
        var controller = new HomeController(rep.Object);

        // Act
        string result = controller.ViewBag.UserEmail;

        // Assert
        Assert.AreEqual(email, result);
    }

I assume that this test must pass, but it fails with message Assert.AreEqual failed. Expected:<[email protected]>. Actual:<(null)>.

What am I doing wrong?

Thanks

This doesn't work at all, tried it, got an exception Test method HomeControllerTest.Index_Action_Test threw exception: Microsoft.CSharp.RuntimeBinder.RuntimeBinderException: Cannot apply indexing with [] to an expression of type 'System.Dynamic.DynamicObject' — Burjua
– Burjua, Commented Aug 31, 2011 at 12:31

archil · Accepted Answer · 2011-08-31 12:38:57Z

4

Simple - you do not do Act part correctly. Fisrt you should call Index() action of the controller, and then Assert ViewBag.UserEmail correctness

// Act
        controller.Index();
        string result = controller.ViewBag.UserEmail;

By the way, advice - Using ViewBag is not the good practice. Define ViewModels instead

answered Aug 31, 2011 at 12:38

archil

39.6k7 gold badges69 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Burjua Over a year ago

Yes, you are right, it works now, thanks a lot. And I do use ViewModels, ViewBag is here for simplicity:)

Collectives™ on Stack Overflow

How to use Moq framework correctly - basic question

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related