HttpResponseBase replacement in ASP.NET Core MVC

Question

I have a CustomJsonResult class shown below, which is written in ASP.NET MVC:

using Newtonsoft.Json;
using Newtonsoft.Json.Converters;
using System;
using System.Collections.Generic;
using System.Text;
using System.Web;
using System.Web.Mvc;
using System.Web.Script.Serialization;


namespace Web.Authentication
{
public class CustomJsonResult : JsonResult
{
    public override void ExecuteResult(ControllerContext context)
    {
        if (context == null)
        {
            throw new ArgumentNullException("context");
        }

        HttpResponseBase response = context.HttpContext.Response;

        if (!String.IsNullOrEmpty(ContentType))
        {
            response.ContentType = ContentType;
        }
        else
        {
            response.ContentType = "application/json";
        }
        if (ContentEncoding != null)
        {
            response.ContentEncoding = ContentEncoding;
        }
        if (Data != null)
        {                
            var isoConvert = new IsoDateTimeConverter();
            isoConvert.DateTimeFormat = _dateFormat;
            response.Write(JsonConvert.SerializeObject(Data, isoConvert));
        }
    }
}
}

I converted this to ASP.NET Core MVC. For that I changed the HttpResponseBase to HttpResponse and added this namespace using Microsoft.AspNetCore.Http;

using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Newtonsoft.Json;
using Newtonsoft.Json.Converters;
using System;
using System.Collections.Generic;
using System.Text;
using System.Web;
using System.Web.Script.Serialization;


namespace Web.Authentication
{
public class CustomJsonResult : JsonResult
{        
    public override void ExecuteResult(ControllerContext context)
    {
        if (context == null)
        {
            throw new ArgumentNullException("context");
        }

        HttpResponse response = context.HttpContext.Response;

        if (!String.IsNullOrEmpty(ContentType))
        {
            response.ContentType = ContentType;
        }
        else
        {
            response.ContentType = "application/json";
        }
        if (ContentEncoding != null)
        {
            response.ContentEncoding = ContentEncoding;
        }
        if (Data != null)
        {                
            var isoConvert = new IsoDateTimeConverter();
            isoConvert.DateTimeFormat = _dateFormat;
            response.Write(JsonConvert.SerializeObject(Data, isoConvert));
        }
    }
}
}

I'm using this class in controller json method:

[HttpPost]
    [ValidateAntiForgeryToken]
    public JsonResult GetDataRefreshDate()
    {            
        var response = ...
        return new CustomJsonResult()
        {
            Data = response,
            MaxJsonLength = 86753090
        };
    }

But After converting, I'm getting errors like

The type or namespace name 'Script' does not exist in the namespace 'System.Web' (are you missing an assembly reference?)

The name 'Data' does not exist in the current context

'HttpResponse' does not contain a definition for 'Write' and no accessible extension method 'Write' accepting a first argument of type 'HttpResponse' could be found (are you missing a using directive or an assembly reference?)

The name 'ContentEncoding' does not exist in the current context

'CustomJsonResult.ExecuteResult(ControllerContext)': no suitable method found to override

Are you sure you need this code at all? Dates are serialized using the ISO8601 format since Web API 1.0. That's the default format for all .NET Core applications, including ASP.NET Core MVC — Panagiotis Kanavos
– Panagiotis Kanavos, Commented Feb 11, 2022 at 9:17

Ruikai Feng · Accepted Answer · 2022-02-17 01:44:48Z

1

public class CustomJsonResult1 : JsonResult
    {

       
        public CustomJsonResult1(object value) : base(value)
        {
           
        }
        public int MaxJsonLength { get; set; }

        public override Task ExecuteResultAsync(ActionContext context)
        {
            if (context == null)
            {
                throw new ArgumentNullException("context");
            }
            HttpResponse response = context.HttpContext.Response;
            if (!String.IsNullOrEmpty(ContentType))
            {
                response.ContentType = ContentType;
            }
            else
            {
                response.ContentType = "application/json";
            }
            var mediaType = new MediaTypeHeaderValue(ContentType);
            if (mediaType.Encoding != null)
            {
                response.ContentType = response.ContentType;
            }

            if (Value != null)
            {
                var isoConvert = new IsoDateTimeConverter();
                isoConvert.DateTimeFormat = null;

                response.WriteAsync(JsonConvert.SerializeObject(Value, isoConvert));
            }
            return Task.CompletedTask;
        }
    }

In controller：

return new CustomJsonResult1(new { result = false, msg = "???" });

There is no MaxJsonLength property in Jsonresult class in asp.net core. and the "Data"property is replaced with value propert

edited Feb 17, 2022 at 1:44

answered Feb 11, 2022 at 9:13

Ruikai Feng

12.5k1 gold badge7 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user18048414 Over a year ago

I tried above code. It shows no error now. But in controller method, what can be given in place of Data = response and MaxJsonLength = 86753090. Currently it shows this CustomJsonResult class does not contain definition for Data and MaxJsonLength.

Community Over a year ago

Your answer could be improved with additional supporting information. Please edit to add further details, such as citations or documentation, so that others can confirm that your answer is correct. You can find more information on how to write good answers in the help center.

Ruikai Feng Over a year ago

I've updated my answer,please check it

Collectives™ on Stack Overflow

HttpResponseBase replacement in ASP.NET Core MVC

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related