Passing vars in javascript / jquery

Question

I have followed the following link and implemented the example for my own script.

I have 8 file upload inputs followed by a img tag of it's own

<input type="file" name="file[]" accept="image/gif,image/jpeg" onchange="readURL(this,1);"/>
<img id="imagediv1" src="#" alt="your image" />

Now the javascript I modified

function readURL(input,cnum) {
        if (input.files && input.files[0]) {
            var reader = new FileReader();
            var cimage = 'imagediv'+cnum;
            reader.onload = function (e) {
                $("#cimage")
                    .attr('src', e.target.result)
                    .width(150)
                    .height(200);
            };

            reader.readAsDataURL(input.files[0]);
  }     }
}

I did an alert(); within the javascript and the cimage var does get created properly. However, the img doesn't change as it does in the example. I did try manually creating a function for each imagediv#, and it works fine.

Am I missing something within the javascript ?

gilly3 · Accepted Answer · 2011-08-15 17:46:02Z

1

You need to take "cimage" out of the quotes and instead concatenate it to "#":

$("#"+cimage)

Or, better yet, don't bother with creating the cimage variable at all and just do this:

$("#imagediv" + cnum)

answered Aug 15, 2011 at 17:46

gilly3

92.6k26 gold badges148 silver badges179 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Matthew Abbott · Accepted Answer · 2011-08-15 17:47:58Z

0

Change your selector:

$("#" + cimage).attr("src", e.target.result).width(150).height(200);

Your selector $("#cimage") is looking for an element with id="cimage".

answered Aug 15, 2011 at 17:47

Matthew Abbott

61.7k9 gold badges108 silver badges131 bronze badges

Collectives™ on Stack Overflow

Passing vars in javascript / jquery

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related