Input from user to array and Display in Console in C#

Question

I am a Beginner in C# and I was wondering what I got wrong with this code.

I want the user to input the amount of numbers
Then an array with that amount gets created
Then finally I want to display all the numbers in the array.

The Code:

using System;
using System.Threading;
using System.Collections.Generic;

namespace Console_Project_alpha
{
    
class Program 
{
    
    static void Main(string[] args)
    {
            Console.Write("Enter the amount of numbers: ");
            int amount = Convert.ToInt32(Console.ReadLine());
            
            int[] numbers = new int[amount];
            string nth = "";

            
            
            for( int i = 1; i <= amount ; i++)
            {
                        if(i == 1)
                        {
                            nth = i + "st";    
                        }
                        else if( i == 2)
                        {
                           nth = i + "nd";
                        }
                        else if( i == 3)
                        {
                            nth = i + "rd";   
                        }else{
                            nth = i + "th";
                        }
                
                Console.Write("\nEnter " + nth + " Number:");
                int num = Convert.ToInt32(Console.ReadLine());
               
               for(int j = 0; j <= numbers.Length; j++)
                {
                    numbers[j] = num;
                    
                }
                
            }
            System.Console.WriteLine(numbers);

            

    }

   }
}

Any help is highly appreciated. Thanks in advance

It would help of you added the problem that you see. However, here for(int j = 0; j <= numbers.Length; j++) you index past the end of the array. The last index is length-1. — Palle Due
– Palle Due, Commented Oct 5, 2021 at 12:45
If you have an array of length N then the indexes go from 0 to N-1. Replace the <= by < in both loop conditions to fix the problem. — Olivier Jacot-Descombes
– Olivier Jacot-Descombes, Commented Oct 5, 2021 at 12:57

Hararr 1 · Accepted Answer · 2021-10-05 13:58:42Z

1

In your code you all time overwriting the same value to all index in array.
If you want to display values from array in console just iterate after array

Properly worked example based on your code:

class Program
{

    static void Main(string[] args)
    {
        Console.Write("Enter the amount of numbers: ");
        int amount = Convert.ToInt32(Console.ReadLine());

        int[] numbers = new int[amount];
        string nth = "";
        int index = 0;

        for (int i = 1; i <= amount; i++)
        {
            if (i == 1)
            {
                nth = i + "st";
            }
            else if (i == 2)
            {
                nth = i + "nd";
            }
            else if (i == 3)
            {
                nth = i + "rd";
            }
            else
            {
                nth = i + "th";
            }

            Console.Write("\nEnter " + nth + " Number:");
            int num = Convert.ToInt32(Console.ReadLine());

            numbers[index] = num;
            index++;
        }

        for (int i = 0; i <= numbers.Length - 1; i++)
        {
            Console.WriteLine(numbers[i]);
        }

        Console.ReadLine();
    }

}

answered Oct 5, 2021 at 13:58

Hararr 1

262 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

underscore Over a year ago

now I come back and look at it.. this was an easy question I wonder, how in the hell did I ask this.. xD Thanks anyways ;)

Collectives™ on Stack Overflow

Input from user to array and Display in Console in C#

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest