How to properly replace objects in an array - C#

Question

I am trying to remove an object from an array and fill the slot with an object of the same type but with 0s for all the properties. But when I do this the values do not clear for some reason when I recalculate the array values.

Here is how I am clearing an object out and inserting a blank one in its place.

    public void clearOutBox(int arraySlot)
    {
        itemsInbuildArray.Remove(itemsArray[arraySlot]);
        itemsInbuildArray.Insert(arraySlot, blank);
        itemInBuildPictureArray[arraySlot].ImageLocation = null;
        statCalculation();
    }

    //one of the lines from the statCalculation method. 
    statsHealth.Text = (Convert.ToString(itemsInbuildArray.Sum(hp => hp.Health)));

        public partial class Form1 : Form
{
    List<Item> itemsArray = new List<Item>();
    List<PictureBox> itemInBuildPictureArray = new List<PictureBox>();
    List<ToolTip> itemInBuildTooltipArray = new List<ToolTip>();
    List<Item> itemsInbuildArray = new List<Item>();
            Item blank = new Item(); // this is one of several objects created here
}

I initialize the array with 6 of these blank items in it and there are no problems replacing a blank item with one with values but removing it is whats causing me issues.

Please excuse the more than likely noobish ways I'm doing this, I am just starting C# and doing this project as a learning experience. Any input is appreciated!

Where is this "blank" object coming from (line #4 in your code) and how do you create it? — Svilen
– Svilen, Commented Jul 25, 2011 at 21:45
You need to give a bit more information - you appear to have 3 array like objects - at least one of which itemsInbuildArray is actually an ArrayList not an Array. — iandotkelly
– iandotkelly, Commented Jul 25, 2011 at 21:52

Dismissile · Accepted Answer · 2011-07-25 21:46:28Z

2

Why not just index it directly:

int index = 5;
array[index] = new Foobar(); // whatever your class is

That is going to change whatever is referenced in the 6th slot in your array.

I would avoid using a single reference called "blank" and putting it into multiple array slots unless you know you will never modify them. If they are reference types then modifying one of them would modify them all.

answered Jul 25, 2011 at 21:46

Dismissile

33.1k40 gold badges179 silver badges269 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mike Over a year ago

blank is just the name of an object. They all have to be blank initially because the values are calculated as each item is entered and if there is not something in there it crashes

Mike Over a year ago

This solved my problem! I guess I was just over complicating it thank you.

Collectives™ on Stack Overflow

How to properly replace objects in an array - C#

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related