How to use finally block when using try-catch in a while loop

Question

I have a usecase , wherein I need to read each line from a csv file : Each line has parameters for a function call. And I call the function for each entry.

while(csvReader.readLine != null){
    try {
        the line is divided into two parameters based on , delimiter;
        call function(line as parameter);
        filePrinter.print(successfulParameter.csv);
    } catch (Exception from function()) {
        log the exception;                  
        anotherFilePrinter.print(unsuccesfulParameter&Exception.csv);
    }
}

I closed all reader, printer...< printer.close() >

Now my code got rejected because , there is a resource leak , i.e; printer is initialised before while loop , as I need it .. and the printer was closed after while loop . it covers just the path where try gets successfully executed, but when it doesn't cover the path where it throws an error , and as this path involving catch block has a resource leak.

Now ,

I can't use printer.close() in catch , as I need the printer again for next try in the while loop.
I can't use finally{printer.close()} in my code , as it gets executed for each try , and I want it just to close after all try statements i.e; all the while loop iterations.

Please let me know how do I do it?

try looking up stackoverflow.com/questions/43441060/…. You actually do not need to use finally block. — dodobird
– dodobird, Commented Jun 29, 2021 at 3:11

Cwift · Accepted Answer · 2021-06-29 06:57:59Z

0

If your printer implements java.lang.AutoCloseable. Just use try-with-resource

answered Jun 29, 2021 at 6:57

Cwift

3102 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sai H. · Accepted Answer · 2021-06-29 03:08:00Z

0

Maybe you can move your while statement inside the try-catch-finally block. And call printer.close() in the finally block.

answered Jun 29, 2021 at 3:08

Sai H.

665 bronze badges

Collectives™ on Stack Overflow

How to use finally block when using try-catch in a while loop

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related