onclick event not invoking a javascript function

Question

Below code in controller and a function getSug(). all this code is inside a angular controller. onclick event doesn't invoke getSug() function. How do i invoke it?

var vm = this;
var quant ="linkClick";
vm.link = '<a onclick="'+vm.getSug();+'">' + quant + '</a>';

function getSug(){}

html:  <table>
            <tr>
              <th>link</th>
              
            </tr>
            <tr>
              <td ng-bind-html="vm.link"></td>
             
            </tr>
          </table>

Why do you need to build the anchor element in this way, as @Kinglish mention in AngularJs you should be using ng-click. — aUXcoder
– aUXcoder, Commented May 28, 2021 at 20:07
only because these links are built using a map and there are multiple links formed dynamically in controller code using the result of an API. i didn't show here to keep it simple — NoStressDeveloper
– NoStressDeveloper, Commented Jun 2, 2021 at 14:27

Kinglish · Accepted Answer · 2021-05-27 19:42:30Z

1

In angularjs, onclick is ng-click

Also you wouldn't write your html that way in angular. Rather it would be:

<table>
 <tr>
  <th>link</th>
 </tr>
 <tr>
  <td>
    <a ng-if='quant' ng-click="getSug()" ng-bind-html="quant"></a> 
  </td>
 </tr>
</table>

Then your function would live in the controller that was associated with that page:

$scope.getSug = function() {
   // code
}

edited May 27, 2021 at 19:42

answered May 27, 2021 at 19:20

Kinglish

23.7k4 gold badges25 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

NoStressDeveloper Over a year ago

i need to invoke it through controller code in the way i declared variable, not this way.

Omri Attiya · Accepted Answer · 2021-05-27 19:20:15Z

0

The function getSug gets called on the 3rd line.

Instead of onclick function you just invoke it at the definition line.

Use

var vm = this;
var quant ="linkClick";
vm.link = '<a onclick="'+"vm.getSug()"+'">' + quant + '</a>';

function getSug(){}

answered May 27, 2021 at 19:20

Omri Attiya

4,0473 gold badges22 silver badges38 bronze badges

Collectives™ on Stack Overflow

onclick event not invoking a javascript function

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related