How to improve Prototype.js callback function code

Question

I have this small code. I am using the Prototype framework but I am unable to bind elements to the callback function. That's why I have to write the function like this.

How may I improve this code?

 Event.observe('firstname', 'keyup', function () {
     var form = $('customerform'),
         firstname_0 = form["firstname_0"];
     firstname.value = this.value;
 });
 Event.observe('KundeNachname', 'keyup', function () {
     var form = $('customerform'),
         lastname_0 = form["lastname_0"];
     lastname_0.value = this.value;
 });

Wayne · Accepted Answer · 2011-07-18 16:48:14Z

1

The only difference between each of your callbacks is the name of the form field that's referenced. I'd extract that code into a common callback-creating function:

function createHandler(fieldName) {
    return function() {
        $('customerform')[fieldName].value = this.value;
    }
}

Event.observe('firstname', 'keyup', createHandler("firstname_0"));
Event.observe('KundeNachname', 'keyup', createHandler("lastname_0"));

answered Jul 18, 2011 at 16:48

Wayne

60.5k15 gold badges135 silver badges129 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gabi Purcaru · Accepted Answer · 2011-07-18 16:48:36Z

1

$('customerform')['lastname_0'].value = this.value;

This condenses your three lines of code into one.

edited Jul 18, 2011 at 16:48

answered Jul 18, 2011 at 16:43

Gabi Purcaru

31.7k9 gold badges81 silver badges96 bronze badges

1 Comment

McKayla Over a year ago

Shouldn't it be $('customerform')['lastname_0'].value = this.value;?

Collectives™ on Stack Overflow

How to improve Prototype.js callback function code

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related