I have a text file that follows:
Run
Jump
Jump
Swim
Run
And I have 3 methods, run, jump and swim, how do I run those functions when each of those lines gets read, so it would run "Run" first and that would run the run function then it would run the "Jump" function twice ect, ive been stuck for 2 days and thought a hint would be much appreciated, thanks! ^-^
I think you should just have a dictionary that holds commands+functions:
def jump():
player.y += 10
...
commands = {"jump":jump,"Run":run,"Swim":swim}
for cmd in command_file.split("\n"):
commands.get(cmd.strip())()
get( ), rather than just [cmd.strip()]: the only difference it will cause is that instead of getting a KeyError if the cmd from the file is invalid (with the invalid key actually in the error message), whereas your code will generate a ValueError: NoneType is not callable Exception which is a lot less useful..
This is what I would do :
def run():
print('Running')
def jump():
print('Jump')
def swim():
print('Swim')
commands_table = {'Run':run, 'Jump':jump, 'Swim':swim}
with open('commands.txt', 'r') as command_file:
for cmd in command_file:
cmd = cmd.strip()
commands_table[cmd]()
We use a dictionary to store the relationship between the commands in the text file and the functions that need to be executed.
The with statement and beyond opens the text file, reads the commands in, removes any whitespace and then executes the function by extracting it from the dictionary.
commands.readlines() )readlines() if you are using a for loop on an open file. An open file works like a container of lines, so doing readlines() is redundant.